Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: use self instead of window or document for worker context #16

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

krissvaa
Copy link

Adjust the library to be used in the Service Worker context without DOM global variables

Fixes vaadin/hilla#2867

@CLAassistant
Copy link

CLAassistant commented Nov 11, 2024

CLA assistant check
All committers have signed the CLA.

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.31%. Comparing base (c67a967) to head (aaed4b3).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #16   +/-   ##
=======================================
  Coverage   98.30%   98.31%           
=======================================
  Files           3        3           
  Lines         650      651    +1     
  Branches       37       37           
=======================================
+ Hits          639      640    +1     
  Misses         11       11           
Flag Coverage Δ
unittests 98.31% <ø> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

PWA endpoint errors while called from SW
3 participants