docs: enhance dialog component documentation with positioning and sizing details #3946
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Language unchecked
…ic positioning and sizing details
vursen
reviewed
Nov 26, 2024
Comment on lines
+204
to
+207
| Dialogs can be positioned in two ways: | ||
|
|
||
| . [since:com.vaadin:[email protected]]##By setting fixed coordinates programmatically## | ||
| . By allowing the user to drag them (see <<Draggable>>) |
There was a problem hiding this comment.
This gave me the impression that these two ways mutually exclude each other, but that's not the case, if I understand correctly. You can set the initial position using the top and left properties and still enable dragging, right? The same goes for resizing.
There was a problem hiding this comment.
Yeah, both cases can work at the same time. I don't have the same impression, but I can be a bit biased. I can try to improve it to remove any misunderstanding.
Co-authored-by: Sergey Vinogradov <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Create new "Position" and "Size" sections and move "Draggable" and "Rezizable" sections to the corresponding ones.
Also add code snippets showing the new API for programmatically sizing and positioning.