Implement proper text shaping #150
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hasenbanck
force-pushed
the
text_shaping
branch
2 times, most recently
from
3ede61a
to
3546ff2
Compare
This replaces rusttypes with cosmic_text, which implements a layout engine and proper text shaping. We don't use it to the fullest yet, but that would require a redesign of how we handle text in our interface. I changed the sampler for text to nearest, which results in much shaper text.
hasenbanck
force-pushed
the
text_shaping
branch
from
3546ff2
to
f86b56c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This replaces rusttypes with cosmic_text, which implements a layout engine and proper text shaping. We have to do glyph caching on our own, but that isn't very hard to do (we have an online texture cache to do that).
We don't use it to the fullest yet, but that would require a redesign of how we handle text in our interface.
I changed the sampler for text to nearest, which results in much shaper text.
@vE5li I would like to call
FontLoader::clear()when the application's scaling factor changes, but I haven't found a good way to do so yet.