Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Script for processing a video and generating SECTIONED_V2 artifacts for read-only item registration #980

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

AndriiKlymchuk
Copy link
Contributor

@AndriiKlymchuk AndriiKlymchuk commented Dec 12, 2024

Problem

For read only registration of videos in SECTIONED_V2 format clients need to prepare all processing artifacts them-self.
It is very complicated as requires to perform a lot of steps.

Solution

Develop script that creates all artifacts and generates metadata file that contains payload for registration as well as storage keys mapping to upload files.

We plan to send this script to J&J and later make it part of darwin py with proper code organization and test coverage.

This PR doesn't have to be merged, but rather reviewed and closed in favor of proper implementation as part of darwin py that will be done later

Copy link

linear bot commented Dec 12, 2024

@AndriiKlymchuk AndriiKlymchuk force-pushed the dar-5094-create-python-script-to-generate-video-artifacts-for-read branch from 7e3240d to ccbe1f7 Compare December 12, 2024 12:59
@JBWilkie
Copy link
Collaborator

Looks good, and works well when I test it. To get into the repo I think we should consider:

  • Allowing the script to process multiple videos from a single command, perhaps it could work on a directory of files
  • Adding an explicit warning / documentation stating that this may become out of sync with our backend video processing pipeline
  • Placing it in a new darwin/scripts directory or similar, as no scripts of this type exist in darwin-py currently

@AndriiKlymchuk
Copy link
Contributor Author

Looks good, and works well when I test it. To get into the repo I think we should consider:

  • Allowing the script to process multiple videos from a single command, perhaps it could work on a directory of files
  • Adding an explicit warning / documentation stating that this may become out of sync with our backend video processing pipeline
  • Placing it in a new darwin/scripts directory or similar, as no scripts of this type exist in darwin-py currently

Agree. Also we need to cover it by tests.
I also sync maybe it shouldn't be a separate script, but rather part of darwin py cli?

@AndriiKlymchuk AndriiKlymchuk force-pushed the dar-5094-create-python-script-to-generate-video-artifacts-for-read branch from ccbe1f7 to 8f02a99 Compare December 13, 2024 21:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants