Integrate with argo workflow via vineyardctl. #1593
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dashanji
force-pushed
the
integrate-with-argo-workflow
branch
2 times, most recently
from
390c43e to
739edc7
Compare
dashanji
force-pushed
the
integrate-with-argo-workflow
branch
from
739edc7 to
78a5fbf
Compare
sighingnow
approved these changes
Oct 18, 2023
| --mount-path="/vineyard/data" \ | ||
| --dag="dag" \ | ||
| --tasks="preprocess-data,test-data" | ||
| `) |
There was a problem hiding this comment.
Can you use a simpler demo case in docstring? for example a workflow with only 2 step.
|
|
||
| "github.com/v6d-io/v6d/k8s/cmd/commands/flags" | ||
| "github.com/v6d-io/v6d/k8s/cmd/commands/util" | ||
| "gopkg.in/yaml.v3" |
There was a problem hiding this comment.
Leave vineyard imports to the last position.
* Add a new command 'vineyardctl inject argo-workflow' to inject the vineyard volumes to the workflow manifest. * Add the relevant unit test. * Update the doc. * Bump up the golangci-lint to v1.50.0. Signed-off-by: Ye Cao <[email protected]>
Signed-off-by: Ye Cao <[email protected]>
Signed-off-by: Ye Cao <[email protected]>
dashanji
force-pushed
the
integrate-with-argo-workflow
branch
from
052cddb to
c2704c0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What do these changes do?
Related issue number
Fixes #1590