Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make a deep copy of a map value and add more logs when processing and pushing metrics #9473

Merged
merged 2 commits into from
Nov 15, 2024

Conversation

srbarrios
Copy link
Member

@srbarrios srbarrios commented Nov 13, 2024

What does this PR change?

  • Make a deep copy when we retrieve the value of a map
  • Add more logs when processing and pushing metrics

GUI diff

No difference.

  • DONE

Documentation

  • No documentation needed

  • DONE

Test coverage

ℹ️ If a major new functionality is added, it is strongly recommended that tests for the new functionality are added to the Cucumber test suite

  • Cucumber tests were improved

  • DONE

Links

Ports:

Changelogs

Make sure the changelogs entries you are adding are compliant with https://github.com/uyuni-project/uyuni/wiki/Contributing#changelogs and https://github.com/uyuni-project/uyuni/wiki/Contributing#uyuni-projectuyuni-repository

If you don't need a changelog check, please mark this checkbox:

  • No changelog needed

If you uncheck the checkbox after the PR is created, you will need to re-run changelog_test (see below)

Re-run a test

If you need to re-run a test, please mark the related checkbox, it will be unchecked automatically once it has re-run:

  • Re-run test "changelog_test"
  • Re-run test "backend_unittests_pgsql"
  • Re-run test "java_lint_checkstyle"
  • Re-run test "java_pgsql_tests"
  • Re-run test "ruby_rubocop"
  • Re-run test "schema_migration_test_pgsql"
  • Re-run test "susemanager_unittests"
  • Re-run test "javascript_lint"
  • Re-run test "spacecmd_unittests"

Before you merge

Check How to branch and merge properly!

@srbarrios srbarrios requested a review from a team as a code owner November 13, 2024 16:06
Copy link
Contributor

👋 Hello! Thanks for contributing to our project.
Acceptance tests will take some time (aprox. 1h), please be patient ☕
You can see the progress at the end of this page and at https://github.com/uyuni-project/uyuni/pull/9473/checks
Once tests finish, if they fail, you can check 👀 the cucumber report. See the link at the output of the action.
You can also check the artifacts section, which contains the logs at https://github.com/uyuni-project/uyuni/pull/9473/checks.

If you are unsure the failing tests are related to your code, you can check the "reference jobs". These are jobs that run on a scheduled time with code from master. If they fail for the same reason as your build, it means the tests or the infrastructure are broken. If they do not fail, but yours do, it means it is related to your code.

Reference tests:

KNOWN ISSUES

Sometimes the build can fail when pulling new jar files from download.opensuse.org . This is a known limitation. Given this happens rarely, when it does, all you need to do is rerun the test. Sorry for the inconvenience.

For more tips on troubleshooting, see the troubleshooting guide.

Happy hacking!
⚠️ You should not merge if acceptance tests fail to pass. ⚠️

@srbarrios srbarrios changed the title Add more logs when processing and pushing metrics (#25785) Add more logs when processing and pushing metrics Nov 14, 2024
@srbarrios srbarrios force-pushed the qe-verbose-report-metrics branch 4 times, most recently from bca834d to 71a2ead Compare November 14, 2024 19:21
@srbarrios srbarrios changed the title Add more logs when processing and pushing metrics Make a deep copy of a map value and add more logs when processing and pushing metrics Nov 15, 2024
@srbarrios srbarrios self-assigned this Nov 15, 2024
Copy link
Contributor

@Bischoff Bischoff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure that "evaluate" is more understandable than "wait"...

Copy link
Contributor

@ktsamis ktsamis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure about the consequences of this but it doesn't look to break stuff. We have to see if the dig+clone will have any other consequences (I think not) and the evaluate is a bit different way of checking the channels, not sure how it would work on some maybe corner cases. But I think we should try this :)

@srbarrios srbarrios merged commit 2eb4a6a into master Nov 15, 2024
16 checks passed
@srbarrios srbarrios deleted the qe-verbose-report-metrics branch November 15, 2024 11:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants