Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove removed -l option of mgr-setup #9463

Merged
merged 1 commit into from
Nov 14, 2024

Conversation

aaannz
Copy link
Contributor

@aaannz aaannz commented Nov 12, 2024

What does this PR change?

Remove removed -l option of mgr-setup and readd missing service stop before modifying/restarting database

GUI diff

No difference.

  • DONE

Documentation

  • No documentation needed: CI testsuite change

  • DONE

Test coverage

ℹ️ If a major new functionality is added, it is strongly recommended that tests for the new functionality are added to the Cucumber test suite

  • No tests: already covered

  • DONE

Links

Issue(s): #
Port(s): # add downstream PR(s), if any

  • DONE

Changelogs

Make sure the changelogs entries you are adding are compliant with https://github.com/uyuni-project/uyuni/wiki/Contributing#changelogs and https://github.com/uyuni-project/uyuni/wiki/Contributing#uyuni-projectuyuni-repository

If you don't need a changelog check, please mark this checkbox:

  • No changelog needed

If you uncheck the checkbox after the PR is created, you will need to re-run changelog_test (see below)

Re-run a test

If you need to re-run a test, please mark the related checkbox, it will be unchecked automatically once it has re-run:

  • Re-run test "changelog_test"
  • Re-run test "backend_unittests_pgsql"
  • Re-run test "java_pgsql_tests"
  • Re-run test "schema_migration_test_pgsql"
  • Re-run test "susemanager_unittests"
  • Re-run test "javascript_lint"
  • Re-run test "spacecmd_unittests"

Before you merge

Check How to branch and merge properly!

@aaannz aaannz requested a review from a team as a code owner November 12, 2024 16:33
Copy link
Contributor

👋 Hello! Thanks for contributing to our project.
Acceptance tests will take some time (aprox. 1h), please be patient ☕
You can see the progress at the end of this page and at https://github.com/uyuni-project/uyuni/pull/9463/checks
Once tests finish, if they fail, you can check 👀 the cucumber report. See the link at the output of the action.
You can also check the artifacts section, which contains the logs at https://github.com/uyuni-project/uyuni/pull/9463/checks.

If you are unsure the failing tests are related to your code, you can check the "reference jobs". These are jobs that run on a scheduled time with code from master. If they fail for the same reason as your build, it means the tests or the infrastructure are broken. If they do not fail, but yours do, it means it is related to your code.

Reference tests:

KNOWN ISSUES

Sometimes the build can fail when pulling new jar files from download.opensuse.org . This is a known limitation. Given this happens rarely, when it does, all you need to do is rerun the test. Sorry for the inconvenience.

For more tips on troubleshooting, see the troubleshooting guide.

Happy hacking!
⚠️ You should not merge if acceptance tests fail to pass. ⚠️

srbarrios
srbarrios previously approved these changes Nov 12, 2024
cbosdo
cbosdo previously approved these changes Nov 13, 2024
@aaannz aaannz dismissed stale reviews from cbosdo and srbarrios via d3f2af5 November 13, 2024 11:45
@aaannz aaannz force-pushed the fixup_ci_mgrsetup branch 2 times, most recently from d3f2af5 to 4d0924d Compare November 13, 2024 11:54
@aaannz aaannz force-pushed the fixup_ci_mgrsetup branch 2 times, most recently from eea71e8 to 7f96a21 Compare November 14, 2024 12:32
susemanager/bin/mgr-setup Outdated Show resolved Hide resolved
@aaannz
Copy link
Contributor Author

aaannz commented Nov 14, 2024

Merging without additional review. Discussion at slack

@aaannz aaannz merged commit 9104e77 into uyuni-project:master Nov 14, 2024
19 checks passed
@aaannz aaannz deleted the fixup_ci_mgrsetup branch November 14, 2024 15:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants