-
Notifications
You must be signed in to change notification settings - Fork 185
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove now unused code from mgr-setup #9450
Conversation
77241f7
to
51716ce
Compare
tested to work here |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, there are just two more nitpicks. But I assume next we well take a look what remains and rework that, so they can be addressed later as well.
Since Uyuni and SUSE Manager are now only shipped in containers there is only one use case of mgr-setup called from mgradm: mgr-setup -s -n. All other flags can go away... even those flags can be removed once mgradm stops using them as they will be the only behavior.
Containerized server does not ship hostname binary and uyuni tools always provide correct hostname as a configuration option.
5958411
to
a941be7
Compare
Addressed |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍🏾
What does this PR change?
Since Uyuni and SUSE Manager are now only shipped in containers there is only one use case of mgr-setup called from mgradm: mgr-setup -s -n. All other flags can go away... even those flags can be removed once mgradm stops using them as they will be the only behavior.
Test coverage
No tests: setup script is only covered with end-to-end tests
DONE
Links
Issue(s): #
Port(s): # add downstream PR(s), if any
Changelogs
Make sure the changelogs entries you are adding are compliant with https://github.com/uyuni-project/uyuni/wiki/Contributing#changelogs and https://github.com/uyuni-project/uyuni/wiki/Contributing#uyuni-projectuyuni-repository
If you don't need a changelog check, please mark this checkbox:
If you uncheck the checkbox after the PR is created, you will need to re-run
changelog_test
(see below)Re-run a test
If you need to re-run a test, please mark the related checkbox, it will be unchecked automatically once it has re-run:
Before you merge
Check How to branch and merge properly!