Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove now unused code from mgr-setup #9450

Merged
merged 2 commits into from
Nov 12, 2024

Conversation

cbosdo
Copy link
Contributor

@cbosdo cbosdo commented Nov 8, 2024

What does this PR change?

Since Uyuni and SUSE Manager are now only shipped in containers there is only one use case of mgr-setup called from mgradm: mgr-setup -s -n. All other flags can go away... even those flags can be removed once mgradm stops using them as they will be the only behavior.

Test coverage

  • No tests: setup script is only covered with end-to-end tests

  • DONE

Links

Issue(s): #
Port(s): # add downstream PR(s), if any

  • DONE

Changelogs

Make sure the changelogs entries you are adding are compliant with https://github.com/uyuni-project/uyuni/wiki/Contributing#changelogs and https://github.com/uyuni-project/uyuni/wiki/Contributing#uyuni-projectuyuni-repository

If you don't need a changelog check, please mark this checkbox:

  • No changelog needed

If you uncheck the checkbox after the PR is created, you will need to re-run changelog_test (see below)

Re-run a test

If you need to re-run a test, please mark the related checkbox, it will be unchecked automatically once it has re-run:

  • Re-run test "changelog_test"
  • Re-run test "backend_unittests_pgsql"
  • Re-run test "java_pgsql_tests"
  • Re-run test "schema_migration_test_pgsql"
  • Re-run test "susemanager_unittests"
  • Re-run test "javascript_lint"
  • Re-run test "spacecmd_unittests"

Before you merge

Check How to branch and merge properly!

@cbosdo
Copy link
Contributor Author

cbosdo commented Nov 8, 2024

tested to work here

aaannz
aaannz previously approved these changes Nov 8, 2024
Copy link
Contributor

@aaannz aaannz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, there are just two more nitpicks. But I assume next we well take a look what remains and rework that, so they can be addressed later as well.

susemanager/bin/mgr-setup Outdated Show resolved Hide resolved
susemanager/bin/mgr-setup Outdated Show resolved Hide resolved
cbosdo and others added 2 commits November 12, 2024 10:17
Since Uyuni and SUSE Manager are now only shipped in containers there is
only one use case of mgr-setup called from mgradm: mgr-setup -s -n. All
other flags can go away... even those flags can be removed once mgradm
stops using them as they will be the only behavior.
Containerized server does not ship hostname binary and uyuni tools
always provide correct hostname as a configuration option.
@cbosdo
Copy link
Contributor Author

cbosdo commented Nov 12, 2024

LGTM, there are just two more nitpicks. But I assume next we well take a look what remains and rework that, so they can be addressed later as well.

Addressed

Copy link
Contributor

@aaannz aaannz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏾

@cbosdo cbosdo merged commit b4ca421 into uyuni-project:master Nov 12, 2024
18 checks passed
@cbosdo cbosdo deleted the setup-cleanup branch November 12, 2024 14:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants