Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix uyuni proxy sync #9439

Merged
merged 4 commits into from
Nov 17, 2024

Conversation

maximenoel8
Copy link
Contributor

@maximenoel8 maximenoel8 commented Nov 5, 2024

What does this PR change?

Uyuni product synchronized for proxy is not correct.

GUI diff

No difference.

  • DONE

Documentation

  • No documentation needed: only internal and user invisible changes

  • DONE

Test coverage

ℹ️ If a major new functionality is added, it is strongly recommended that tests for the new functionality are added to the Cucumber test suite

  • No tests: already covered

  • DONE

Links

Port:
Issue:

  • DONE

Changelogs

Make sure the changelogs entries you are adding are compliant with https://github.com/uyuni-project/uyuni/wiki/Contributing#changelogs and https://github.com/uyuni-project/uyuni/wiki/Contributing#uyuni-projectuyuni-repository

If you don't need a changelog check, please mark this checkbox:

  • No changelog needed

If you uncheck the checkbox after the PR is created, you will need to re-run changelog_test (see below)

Re-run a test

If you need to re-run a test, please mark the related checkbox, it will be unchecked automatically once it has re-run:

  • Re-run test "changelog_test"
  • Re-run test "backend_unittests_pgsql"
  • Re-run test "java_lint_checkstyle"
  • Re-run test "java_pgsql_tests"
  • Re-run test "ruby_rubocop"
  • Re-run test "schema_migration_test_pgsql"
  • Re-run test "susemanager_unittests"
  • Re-run test "javascript_lint"
  • Re-run test "spacecmd_unittests"

Before you merge

Check How to branch and merge properly!

@maximenoel8 maximenoel8 requested a review from a team as a code owner November 5, 2024 19:44
Copy link
Contributor

github-actions bot commented Nov 5, 2024

👋 Hello! Thanks for contributing to our project.
Acceptance tests will take some time (aprox. 1h), please be patient ☕
You can see the progress at the end of this page and at https://github.com/uyuni-project/uyuni/pull/9439/checks
Once tests finish, if they fail, you can check 👀 the cucumber report. See the link at the output of the action.
You can also check the artifacts section, which contains the logs at https://github.com/uyuni-project/uyuni/pull/9439/checks.

If you are unsure the failing tests are related to your code, you can check the "reference jobs". These are jobs that run on a scheduled time with code from master. If they fail for the same reason as your build, it means the tests or the infrastructure are broken. If they do not fail, but yours do, it means it is related to your code.

Reference tests:

KNOWN ISSUES

Sometimes the build can fail when pulling new jar files from download.opensuse.org . This is a known limitation. Given this happens rarely, when it does, all you need to do is rerun the test. Sorry for the inconvenience.

For more tips on troubleshooting, see the troubleshooting guide.

Happy hacking!
⚠️ You should not merge if acceptance tests fail to pass. ⚠️

srbarrios
srbarrios previously approved these changes Nov 11, 2024
@@ -794,7 +794,7 @@ Feature: Synchronize products in the products page of the Setup Wizard
@uyuni
@proxy
Scenario: Add Uyuni Leap 15.5 Proxy, including Uyuni Client Tools
When I use spacewalk-common-channel to add all "leap15.5" channels with arch "x86_64"
When I use spacewalk-common-channel to add all "uyuni-proxy" channels with arch "x86_64"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The channels synchronized seems correct, but.. I wonder at which point we include the correct repository for the mgr-tools (in particular mgrpxy) during the CI.
I guess... we only do it on sumaform, and we rely on it, right? If that's the case, maybe it gonna be good a comment somewhere in this feature to explain that we skip that step because we do directly on deployment.

zypper ar https://download.opensuse.org/repositories/systemsmanagement:/Uyuni:/Stable/images/repo/Uyuni-Proxy-POOL-x86_64-Media1/

image

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is done during combustion.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

But in combustion we might be passing Stable or Master as repos, but... not the one coming from the MIs, as far as I know we don't handle MI injections in combustion.

Copy link
Contributor Author

@maximenoel8 maximenoel8 Nov 17, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you mean the repositories from additional_repository variable ?
We do now add those repositories into combustion: https://github.com/uyuni-project/sumaform/blob/addeb4382c1c77c2e84f8e7644d66319fa28361e/backend_modules/libvirt/host/combustion#L97C1-L105C5

That what trigger me to open this issue: https://github.com/SUSE/spacewalk/issues/25609

@maximenoel8 maximenoel8 merged commit 516f35c into uyuni-project:master Nov 17, 2024
16 checks passed
@maximenoel8 maximenoel8 deleted the fix_uyuni_proxy_sync branch November 17, 2024 20:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants