-
Notifications
You must be signed in to change notification settings - Fork 185
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove snaposhot and export tools #9424
Remove snaposhot and export tools #9424
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No, we do not want these tools. They are not supported.
I need to check all of them, but from my point of view there is a reason why they are in an unsupported extra package
@mcalmer I was following what was discussed with @admd in this confluence page: https://confluence.suse.com/display/~RDiasMateus/SUMA+cmd+tools I would love to completely remove the remaining tools from this package (tasktop is already moved to the regular package, so that can be kept). But to remove all I would need @admd agreement, and I'm not sure if we must first document that those are deprecated. |
Maybe I can split the PR in 2, one to remove the tools we know we can remove, and another one to see if we want to install the extras package in the container |
@juliogonzalez had the idea of moving it to the contrib repository. And looking with more attention to the confluence page, I think that was what @admd and I had discussed for the majority of the tool. |
@rjmateus I just saw the description of spacewalk-utils-extra package that states
I didn’t know about this before. So, @mcalmer is correct—we can safely remove the entire package. The only regularly used component is taskotop, and if I understand correctly, it’s already covered. |
Ok, that makes sense. |
Should we comment it at the release notes, at least for Uyuni? |
@mcalmer I will keep this PR like it's now, just removing the dead tools. I will open a new one with the other tools, and then it can be announced to uyuni release notes. |
c8f1452
to
c3f4c5a
Compare
Signed-off-by: Ricardo Mateus <[email protected]>
Signed-off-by: Ricardo Mateus <[email protected]>
Signed-off-by: Ricardo Mateus <[email protected]>
36f895f
to
320e437
Compare
What does this PR change?
Install the spacewalk-extra-utils since it still contains some utility tools. Several of those tools needs to be migrated, but until that, we must install the package.
Partially reverts: #9251
GUI diff
No difference.
Documentation
No documentation needed. I didn't removed it in the old documentation. Also, those tools where not documented.
DONE
Test coverage
No tests: old toos, so no tests.
DONE
Links
Issue(s): #9403
Port(s): Needs to be ported to 5.0
Changelogs
Make sure the changelogs entries you are adding are compliant with https://github.com/uyuni-project/uyuni/wiki/Contributing#changelogs and https://github.com/uyuni-project/uyuni/wiki/Contributing#uyuni-projectuyuni-repository
If you don't need a changelog check, please mark this checkbox:
If you uncheck the checkbox after the PR is created, you will need to re-run
changelog_test
(see below)Re-run a test
If you need to re-run a test, please mark the related checkbox, it will be unchecked automatically once it has re-run:
Before you merge
Check How to branch and merge properly!