Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove snaposhot and export tools #9424

Merged
merged 3 commits into from
Nov 6, 2024

Conversation

rjmateus
Copy link
Member

What does this PR change?

Install the spacewalk-extra-utils since it still contains some utility tools. Several of those tools needs to be migrated, but until that, we must install the package.

Partially reverts: #9251

GUI diff

No difference.

Documentation

  • No documentation needed. I didn't removed it in the old documentation. Also, those tools where not documented.

  • DONE

Test coverage

  • No tests: old toos, so no tests.

  • DONE

Links

Issue(s): #9403
Port(s): Needs to be ported to 5.0

  • DONE

Changelogs

Make sure the changelogs entries you are adding are compliant with https://github.com/uyuni-project/uyuni/wiki/Contributing#changelogs and https://github.com/uyuni-project/uyuni/wiki/Contributing#uyuni-projectuyuni-repository

If you don't need a changelog check, please mark this checkbox:

  • No changelog needed

If you uncheck the checkbox after the PR is created, you will need to re-run changelog_test (see below)

Re-run a test

If you need to re-run a test, please mark the related checkbox, it will be unchecked automatically once it has re-run:

  • Re-run test "changelog_test"
  • Re-run test "backend_unittests_pgsql"
  • Re-run test "java_pgsql_tests"
  • Re-run test "schema_migration_test_pgsql"
  • Re-run test "susemanager_unittests"
  • Re-run test "javascript_lint"
  • Re-run test "spacecmd_unittests"

Before you merge

Check How to branch and merge properly!

@rjmateus rjmateus requested a review from a team as a code owner October 31, 2024 15:24
@rjmateus rjmateus requested review from m-czernek and mcalmer and removed request for a team October 31, 2024 15:24
Copy link
Contributor

@mcalmer mcalmer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, we do not want these tools. They are not supported.
I need to check all of them, but from my point of view there is a reason why they are in an unsupported extra package

@rjmateus
Copy link
Member Author

@mcalmer I was following what was discussed with @admd in this confluence page: https://confluence.suse.com/display/~RDiasMateus/SUMA+cmd+tools

I would love to completely remove the remaining tools from this package (tasktop is already moved to the regular package, so that can be kept). But to remove all I would need @admd agreement, and I'm not sure if we must first document that those are deprecated.
Also, what should we do to these tools on 5.0 and 5.1?

@rjmateus
Copy link
Member Author

Maybe I can split the PR in 2, one to remove the tools we know we can remove, and another one to see if we want to install the extras package in the container

@rjmateus
Copy link
Member Author

@juliogonzalez had the idea of moving it to the contrib repository. And looking with more attention to the confluence page, I think that was what @admd and I had discussed for the majority of the tool.
Let's talk next week, but maybe I can move must of the scripts to the contrib repo, and the one or two we want to support, move to the spacewalk-utils package instead the extra, like we did with tasktop.

@admd
Copy link
Contributor

admd commented Nov 1, 2024

@rjmateus I just saw the description of spacewalk-utils-extra package that states

Extra utilities that may be run against a SUSE Manager server (unsupported) or an Uyuni server

I didn’t know about this before. So, @mcalmer is correct—we can safely remove the entire package. The only regularly used component is taskotop, and if I understand correctly, it’s already covered.

@rjmateus
Copy link
Member Author

rjmateus commented Nov 4, 2024

Ok, that makes sense.
Taskotop was moved to the package spacewalk-utils, so it means it is supported.
I will then change the PR to not install the extras on the image, and remove the other tools and extras package. At same time I will move some of the tools to the contrib repo (according to the document in confluence).
@mcalmer @admd makes sense for you?

@rjmateus rjmateus changed the title Install utils extra package on server image and clean old code Remove snaposhot and export tools Nov 4, 2024
@juliogonzalez
Copy link
Member

I will then change the PR to not install the extras on the image, and remove the other tools and extras package. At same time I will move some of the tools to the contrib repo (according to the document in confluence).

Should we comment it at the release notes, at least for Uyuni?

@rjmateus
Copy link
Member Author

rjmateus commented Nov 4, 2024

@mcalmer I will keep this PR like it's now, just removing the dead tools. I will open a new one with the other tools, and then it can be announced to uyuni release notes.
Could you review it? Thank you

@rjmateus rjmateus merged commit 35f50b1 into uyuni-project:master Nov 6, 2024
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants