Fix coverity hits in Classifier, Decision Forest and GBT #3001
+99
−1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rule of three violations were fixed mostly by adding default implementations or deleting copy constructors and assignment operators.
The default implementations were added into
Parameter
,Input
,InputIface
,Model
,ModelImpl
classes as they are meant to be copy-assignable and copy-constructible.Non-default implementations of copy constructor and assignment operator were added in GBT
ModelImpl
and multiclass classifierModel
classes because they contain non-POD members.In the internal classes that do not need to be copyable the copy constructors and assignment operators were deleted.
PR completeness and readability
Testing