-
Notifications
You must be signed in to change notification settings - Fork 215
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: array coverity hits #2988
fix: array coverity hits #2988
Conversation
/intelci: run |
Internal CI fails unrelated, to be fixed in uxlfoundation/scikit-learn-intelex#2190 |
Error from the public CI job reads as follows:
It means the job doesn't have |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
/intelci: run |
Co-authored-by: Victoriya Fedotova <[email protected]>
Co-authored-by: Victoriya Fedotova <[email protected]>
/intelci: run |
Description
Addresses 2 array hits in coverity.
PR should start as a draft, then move to ready for review state after CI is passed and all applicable checkboxes are closed.
This approach ensures that reviewers don't spend extra time asking for regular requirements.
You can remove a checkbox as not applicable only if it doesn't relate to this PR in any way.
For example, PR with docs update doesn't require checkboxes for performance while PR with any change in actual code should have checkboxes and justify how this code change is expected to affect performance (or justification should be self-evident).
Checklist to comply with before moving PR from draft:
PR completeness and readability
Testing