Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: array coverity hits #2988

Merged
merged 7 commits into from
Dec 11, 2024

Conversation

ethanglaser
Copy link
Contributor

@ethanglaser ethanglaser commented Nov 26, 2024

Description

Addresses 2 array hits in coverity.


PR should start as a draft, then move to ready for review state after CI is passed and all applicable checkboxes are closed.
This approach ensures that reviewers don't spend extra time asking for regular requirements.

You can remove a checkbox as not applicable only if it doesn't relate to this PR in any way.
For example, PR with docs update doesn't require checkboxes for performance while PR with any change in actual code should have checkboxes and justify how this code change is expected to affect performance (or justification should be self-evident).

Checklist to comply with before moving PR from draft:

PR completeness and readability

  • I have reviewed my changes thoroughly before submitting this pull request.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have updated the documentation to reflect the changes or created a separate PR with update and provided its number in the description, if necessary.
  • Git commit message contains an appropriate signed-off-by string (see CONTRIBUTING.md for details).
  • I have added a respective label(s) to PR if I have a permission for that.
  • I have resolved any merge conflicts that might occur with the base branch.

Testing

  • I have run it locally and tested the changes extensively.
  • All CI jobs are green or I have provided justification why they aren't.
  • I have extended testing suite if new functionality was introduced in this PR.

@ethanglaser
Copy link
Contributor Author

/intelci: run

@ethanglaser ethanglaser marked this pull request as draft November 26, 2024 19:12
@ethanglaser
Copy link
Contributor Author

ethanglaser commented Nov 26, 2024

Internal CI fails unrelated, to be fixed in uxlfoundation/scikit-learn-intelex#2190
Not sure about public CI though

@ethanglaser ethanglaser marked this pull request as ready for review November 26, 2024 23:23
@david-cortes-intel
Copy link
Contributor

Error from the public CI job reads as follows:

Info from 'helper_mpi_tests.py'
sys.argv: ['/home/vsts/work/1/s/sklearnex/tests/helper_mpi_tests.py', 'pytest', '-k', 'spmd', '--with-mpi', '--verbose', '--pyargs', 'sklearnex']
ERROR: usage: helper_mpi_tests.py [options] [file_or_dir] [file_or_dir] [...]
helper_mpi_tests.py: error: unrecognized arguments: --with-mpi
  inifile: /home/vsts/work/1/s/sklearnex/pyproject.toml
  rootdir: /home/vsts/work/1/s/sklearnex

It means the job doesn't have pytest-mpi installed, which is required for running the SPMD tests.

Copy link
Contributor

@Vika-F Vika-F left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ethanglaser ethanglaser marked this pull request as draft December 5, 2024 04:05
@ethanglaser ethanglaser requested a review from Vika-F December 6, 2024 21:31
cpp/oneapi/dal/array.hpp Outdated Show resolved Hide resolved
@ethanglaser
Copy link
Contributor Author

/intelci: run

@ethanglaser
Copy link
Contributor Author

/intelci: run

@ethanglaser ethanglaser marked this pull request as ready for review December 10, 2024 18:26
@Vika-F Vika-F merged commit 1d5b01f into uxlfoundation:main Dec 11, 2024
19 of 20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants