Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added C&C_patient_management.drawio #24

Open
wants to merge 40 commits into
base: main
Choose a base branch
from
Open

Conversation

minhn201
Copy link
Contributor

image
This is not the picture of the exact file, but representative nonetheless

@lapis2002
Copy link
Contributor

Left some comments on the image, they’re basically the same things we discussed in lab
78718C8D-E3E3-453F-B66B-0B955877A1C2

@minhn201
Copy link
Contributor Author

Update Patient Management component

image

@minhn201
Copy link
Contributor Author

C C_patient_management drawio

@minhn201
Copy link
Contributor Author

patient_management_dc

Will add more files in due time
@lapis2002
Copy link
Contributor

Update Patient Management component

image

Left some comments below. Let me know how you think
6BE76AB7-C798-447D-AFA0-C1D786BB8223

@lapis2002
Copy link
Contributor

patient_management_dc

I think we only need 1 database Patient instead of 3 separate DBs: Triage, Account, Health. Since they are all related to patient and can join together by the key PatientID. I would suggest that we have PatientDB with 4 tables: TriageRecords- schema TriageRecordsSchema (contains triage record, with TriageID as primary key), UserHealthInfo - schema UserHealthInfoSchema (contains user health record for for patient, primary key is PatientID), AccountInfo - schema AccountInfoSchema (contains account related info (name, username, pw, address, email, phone), primary key is PatientID).

@minhn201
Copy link
Contributor Author

image

@minhn201
Copy link
Contributor Author

patient_management_dc (1)

@lapis2002
Copy link
Contributor

Both diagrams good to me. Can you update the description for them by tonight? Thanks!

Copy link
Contributor

@lapis2002 lapis2002 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's missing the mocking API.

@minhn201
Copy link
Contributor Author

minhn201 commented Oct 15, 2023

Mock API server
Screen Shot 2023-10-14 at 11 52 29 PM

Making a mock GET request
Screen Shot 2023-10-14 at 11 53 53 PM

Copy link
Contributor

@lapis2002 lapis2002 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the function should return a JSON object. Also, FastApi has a section on how to verify user login that we can use as reference.

@minhn201
Copy link
Contributor Author

I think the function should return a JSON object. Also, FastApi has a section on how to verify user login that we can use as reference.

@lapis2002 Which function?

@minhn201
Copy link
Contributor Author

@lapis2002 I think you're referring to user_validation(). I'll change that certainly if that's what you're referring to.

@lapis2002
Copy link
Contributor

@lapis2002 I think you're referring to user_validation(). I'll change that certainly if that's what you're referring to.

The JSON response is about the triages endpoint. It should return a JSON object, sth like this {"triage_history" : []}

@lapis2002
Copy link
Contributor

Also can you record a vid demoing the API? (If you can convert to gif format, it would be great)

@minhn201
Copy link
Contributor Author

minhn201 commented Oct 15, 2023

Video demonstrations:

Activate Server:

Activate.Server.mp4

Log In:

Log.In.mp4

Get Patient's Info:

Get.Patient.Info.mp4

Get Triage List:

Get.Triage.List.mp4

Get Specific Triage:

Get.Triage.mp4

Video on creating an account is to large to be included here, but it is similar to the login demonstration

@minhn201 minhn201 dismissed lapis2002’s stale review October 15, 2023 13:39

Request fulfilled.

@lapis2002
Copy link
Contributor

Mock API server Screen Shot 2023-10-14 at 11 52 29 PM

Making a mock GET request Screen Shot 2023-10-14 at 11 53 53 PM

There should be API endpoints to update/delete user information as well as account information

@minhn201
Copy link
Contributor Author

There should be API endpoints to update/delete user information as well as account information

@lapis2002 we can certainly expand that later. We're only concerned now with what we define in component diagram and use case.

@lapis2002
Copy link
Contributor

Can you mention the component, interface and connector in your component description?

@minhn201
Copy link
Contributor Author

Can you mention the component, interface and connector in your component description?

@lapis2002 Will do

@minhn201
Copy link
Contributor Author

minhn201 commented Oct 15, 2023

Description for Component Diagram:

Components:

The subsystem, which represents Patient Management as a microservice, comprises 5 components:

  • TriageRecordManagement: Provides information to the UI about the patient's triage history by accessing the TriageRecord database.
  • TriageRecord database: Contains information about the patient's triage history.
  • AccountInformationManagement: Handles requests from the patient to create an account and authenticates user credentials for logging in. It also allows patients to access personal health information.
  • HealthInformation database: Contains information about the patient's personal health information.
  • AccountInformation database: Contains information about the patient's user account.

Connectors:

Internal (Within the Patient Management subsystem)

  • TriageRecordManagement requires the TriageInfo interface from the TriageRecord database.
  • AccountInformationManagement requires UserHealthInfo and AccountInfo interfaces from the HealthInformation database and the AccountInformation database, respectively.

External
Between the Patient Management and UI subsystems:

  • The LogIn service component in the UI requires the TriageRecord interface from TriageRecordManagement, as well as the UserInfo and UserValidation interfaces from AccountInformationManagement.
  • The Register service component in the UI requires the UserAccount interface from AccountInformationManagement.
    Between Patient Management and Health Service Management:
  • TriageRecord requires TriageResult from the TriageEngine component in Health Service Management.

@minhn201
Copy link
Contributor Author

Can you mention the component, interface and connector in your component description?

@lapis2002 Will do

@lapis2002 Done

Copy link
Contributor

@OllieWare OllieWare left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants