feat: optimize graphql query performance #54
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
This was
linked to
issues
Aug 2, 2024
Open
ahonn
force-pushed
the
fix/query-performance
branch
from
0243d29 to
b28213c
Compare
Flouse
reviewed
Aug 2, 2024
Flouse
reviewed
Aug 2, 2024
Flouse
reviewed
Aug 2, 2024
| @Cacheable({ | ||
| namespace: 'CkbExplorerService', | ||
| key: (heightOrHash: string) => `getBlock:${heightOrHash}`, | ||
| ttl: ONE_MONTH_MS, |
There was a problem hiding this comment.
If a block reorged, the block height's cache should be updated as well.
So the cache TTL for getBlock(height) may be shorter, while the cache TTL for getBlock(blockHash) can be longer.
Flouse
reviewed
Aug 2, 2024
Flouse
reviewed
Aug 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
fieldPerformanceMiddlewareto log the query time of each field in the QueryCacheabledecorator and add theshouldCachefunction to determine whether the method needs to be cached according to the return value.rgbppLatestTransactionquery to 0.7~2spre-commithook for auto eslint fix, and add eslint rules to avoid direct import ofnestjs-cacheabledecoratorOnUncaughtExceptionissue ERROR [ExceptionHandler] Cannot read properties of undefined (reading 'OnUncaughtException') #36