Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(backend): ensure data loaders and queries are nullable #19

Merged
merged 3 commits into from
Jul 30, 2024

Conversation

ShookLyngs
Copy link
Contributor

Changes

  • Add null check before DataLoader.from() to prevent Cannot read properties of null (reading 'x') issues
  • Replace Promise.all with Promise.allSettled in data loaders to ensure the returns are nullable

@ShookLyngs ShookLyngs requested a review from ahonn July 29, 2024 20:57
Copy link

vercel bot commented Jul 29, 2024

@ShookLyngs is attempting to deploy a commit to the Cell Studio Team on Vercel.

To accomplish this, @ShookLyngs needs to request access to the Team.

Afterwards, an owner of the Team is required to accept their membership request.

If you're already a member of the respective Vercel Team, make sure that your Personal Vercel Account is connected to your GitHub account.

@ShookLyngs ShookLyngs marked this pull request as ready for review July 29, 2024 20:57
@Flouse Flouse requested a review from Vibes-INS July 30, 2024 01:02
@ahonn ahonn merged commit ff11044 into main Jul 30, 2024
3 of 4 checks passed
@ahonn ahonn deleted the fix/query-nullables branch July 30, 2024 01:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants