Merge pull request #186 from utxostack/perf/cache

perf: add cacheable decorator to CKB RPC service & Bitcoin API

backend/src/core/bitcoin-api/bitcoin-api.service.ts

@@ -228,6 +228,11 @@ export class BitcoinApiService {
     return this.call('getTxOutSpends', { txid });
   }
 
+  @Cacheable({
+    namespace: 'bitcoinApiService',
+    key: ({ txids }) => `getTransactionTimes:${txids.join(',')}`,
+    ttl: 10_000,
+  })
   public async getTransactionTimes({ txids }: { txids: string[] }) {
     return this.call('getTransactionTimes', { txids });
   }

backend/src/core/blockchain/blockchain.service.ts

@@ -258,12 +258,7 @@ export class BlockchainService {
     this.logger.debug(
       `get_transactions - searchKey: ${JSON.stringify(searchKey)}, order: ${order}, limit: ${limit}, after: ${after}`,
     );
-    const result = await this.websocket.call('get_transactions', [
-      searchKey,
-      order,
-      limit,
-      after,
-    ]);
+    const result = await this.websocket.call('get_transactions', [searchKey, order, limit, after]);
     const transactions = result as GetTransactionsResult;
     return transactions;
   }

backend/src/core/ckb-explorer/ckb-explorer.service.ts

@@ -6,13 +6,10 @@ import {
   AddressInfo,
   AddressTransactionSortType,
   Block,
-  BlockList,
-  BlockSortType,
   CkbExplorerResponse,
   DetailTransaction,
   NonPaginatedResponse,
   PaginatedResponse,
-  RgbppDigest,
   RgbppTransaction,
   Transaction,
   TransactionSortType,
@@ -21,7 +18,6 @@ import {
   Statistics,
   TransactionFeesStatistic,
   TransactionListSortType,
-  TransactionListItem,
 } from './ckb-explorer.interface';
 import { ONE_MONTH_MS } from 'src/common/date';
 import { CACHE_MANAGER, Cache } from '@nestjs/cache-manager';
@@ -44,10 +40,6 @@ export type GetAddressTransactionsParams = BasePaginationParams & {
   sort?: AddressTransactionSortType;
 };
 
-type GetBlockListParams = BasePaginationParams & {
-  sort?: BlockSortType;
-};
-
 type GetRgbppTransactionsParams = BasePaginationParams & {
   sort?: TransactionSortType;
   leapDirection?: 'in' | 'out';
@@ -64,10 +56,6 @@ type GetXUDTTransactionsParams = BasePaginationParams & {
   addressHash?: string;
 };
 
-type GetTransactionListParams = BasePaginationParams & {
-  sort?: 'height.desc' | 'height.asc';
-};
-
 @Injectable()
 export class CkbExplorerService {
   private logger = new Logger(CkbExplorerService.name);
@@ -119,6 +107,12 @@ export class CkbExplorerService {
     return response.data;
   }
 
+  @Cacheable({
+    namespace: 'CkbExplorerService',
+    key: (address: string, sort, page = 1, pageSize = 10) =>
+      `getAddressTransactions:${address},${sort},${page},${pageSize}`,
+    ttl: 10_000,
+  })
   public async getAddressTransactions({
     address,
     sort,
@@ -135,17 +129,6 @@ export class CkbExplorerService {
     return response.data;
   }
 
-  public async getBlockList({
-    page = 1,
-    pageSize = 10,
-    sort = BlockSortType.HeightDesc,
-  }: GetBlockListParams = {}): Promise<PaginatedResponse<BlockList>> {
-    const response = await this.request.get(
-      `/v1/blocks?page=${page}&page_size=${pageSize}&sort=${sort}`,
-    );
-    return response.data;
-  }
-
   @Cacheable({
     namespace: 'CkbExplorerService',
     key: (heightOrHash: string) => `getBlock:${heightOrHash}`,
@@ -162,20 +145,10 @@ export class CkbExplorerService {
 
   @Cacheable({
     namespace: 'CkbExplorerService',
-    key: (heightOrHash: string, { page = 1, pageSize = 10 }: BasePaginationParams = {}) =>
-      `getBlockTransactions:${heightOrHash},${page},${pageSize}`,
-    ttl: ONE_MONTH_MS,
+    key: (address: string, leapDirection, page = 1, pageSize = 10) =>
+      `getRgbppTransactions:${address},${page},${pageSize},${leapDirection}`,
+    ttl: 10_000,
   })
-  public async getBlockTransactions(
-    blockHash: string,
-    { page = 1, pageSize = 10 }: BasePaginationParams = {},
-  ): Promise<PaginatedResponse<Transaction>> {
-    const response = await this.request.get(
-      `/v1/block_transactions/${blockHash}?page=${page}&page_size=${pageSize}`,
-    );
-    return response.data;
-  }
-
   public async getRgbppTransactions({
     sort = TransactionSortType.NumberDesc,
     page = 1,
@@ -231,31 +204,12 @@ export class CkbExplorerService {
     return response.data;
   }
 
-  public async getTransactionList({
-    page = 1,
-    pageSize = 10,
-    sort = 'height.desc',
-  }: GetTransactionListParams): Promise<PaginatedResponse<TransactionListItem>> {
-    const response = await this.request.get('/v1/transactions', {
-      params: {
-        page,
-        page_size: pageSize,
-        sort,
-      },
-    });
-    return response.data;
-  }
-
   @Cacheable({
     namespace: 'CkbExplorerService',
-    key: (txHash: string) => `getRgbppDigest:${txHash}`,
-    ttl: ONE_MONTH_MS,
+    key: (address: string, tags, sort, page = 1, pageSize = 10) =>
+      `getXUDTList:${address},${tags.join('|')},${sort},${page},${pageSize}`,
+    ttl: 10_000,
   })
-  public async getRgbppDigest(txHash: string): Promise<CkbExplorerResponse<RgbppDigest>> {
-    const response = await this.request.get(`/v2/ckb_transactions/${txHash}/rgb_digest`);
-    return response.data;
-  }
-
   public async getXUDTList({
     symbol,
     tags,
@@ -284,6 +238,12 @@ export class CkbExplorerService {
     return response.data;
   }
 
+  @Cacheable({
+    namespace: 'CkbExplorerService',
+    key: (typeHash: string, { page = 1, pageSize = 10, txHash, addressHash }) =>
+      `getXUDTTransactions:${typeHash},${page},${pageSize},${txHash},${addressHash}`,
+    ttl: 10_000,
+  })
   public async getXUDTTransactions(
     typeHash: string,
     { page = 1, pageSize = 10, txHash, addressHash }: GetXUDTTransactionsParams = {},
@@ -308,7 +268,7 @@ export class CkbExplorerService {
     key: 'getStatistics',
     // Same as the ckb explorer frontend
     // https://github.com/nervosnetwork/ckb-explorer-frontend/blob/develop/src/constants/common.ts#L3
-    ttl: 4000,
+    ttl: 4_000,
   })
   public async getStatistics(): Promise<NonPaginatedResponse<Statistics>> {
     const response = await this.request.get('/v1/statistics');

backend/src/middlewares/field-performance.middleware.ts

@@ -6,20 +6,14 @@ export const fieldPerformanceMiddleware: FieldMiddleware = async (
   next: NextFn,
 ) => {
   const now = performance.now();
-  const memoryUsageNow = process.memoryUsage();
-
   const value = await next();
-
   const executionTime = performance.now() - now;
-  const memoryUsage = process.memoryUsage().heapUsed - memoryUsageNow.heapUsed;
 
   Sentry.setContext('graphql', {
     executionTime,
-    memoryUsage,
     field: ctx.info.fieldName,
     parent: ctx.info.parentType.name,
   });
   Sentry.setMeasurement('graphql.executionTime', executionTime, 'millisecond');
-  Sentry.setMeasurement('graphql.memoryUsage', memoryUsage, 'byte');
   return value;
 };

backend/src/modules/ckb/block/block.service.ts

@@ -11,11 +11,6 @@ export class CkbBlockService {
     private ckbRpcService: CkbRpcWebsocketService,
   ) {}
 
-  public async getLatestBlockNumbers(): Promise<string[]> {
-    const blockList = await this.ckbExplorerService.getBlockList();
-    return blockList.data.map((block) => block.attributes.number);
-  }
-
   public async getBlockFromRpc(heightOrHash: string): Promise<CkbRpc.Block> {
     if (heightOrHash.startsWith('0x')) {
       return await this.ckbRpcService.getBlock(heightOrHash);
@@ -31,9 +26,4 @@ export class CkbBlockService {
   public async getBlockEconomicState(blockHash: string): Promise<CkbRpc.BlockEconomicState> {
     return await this.ckbRpcService.getBlockEconomicState(blockHash);
   }
-
-  public async getBlockTransactions(blockHash: string): Promise<CkbExplorer.Transaction[]> {
-    const blockTransactions = await this.ckbExplorerService.getBlockTransactions(blockHash);
-    return blockTransactions.data.map((transaction) => transaction.attributes);
-  }
 }