Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: handle FailedParsingVssValue when wait device lock syncing #78

Merged
merged 4 commits into from
Dec 27, 2024

Conversation

EthanYuan
Copy link
Collaborator

Handle FailedParsingVssValue when wait device lock syncing, usually it's a failure to parse because it doesn't exist.

Error Handling Improvements:

  • Added FailedParsingVssValue variant to MutinyError and MutinyJsError enums to handle errors when parsing VSS values. (mutiny-core/src/error.rs, mutiny-wasm/src/error.rs) [1] [2]

Device Lock Syncing Logic:

  • Modified the device lock syncing logic in MutinyWalletBuilder to handle retries and specific error logging for VSS parsing failures. (mutiny-core/src/lib.rs)

Version Update:

  • Updated the version of the mutiny-wasm package from 1.10.25 to 1.10.26. (mutiny-wasm/Cargo.toml)

@EthanYuan EthanYuan requested review from duanyytop and jjyr December 27, 2024 03:14
@duanyytop duanyytop requested a review from yuche December 27, 2024 03:28
@duanyytop duanyytop merged commit a2e3c86 into develop Dec 27, 2024
9 checks passed
@duanyytop duanyytop deleted the fix-vss-error branch December 27, 2024 03:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants