Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: save payment info in vss #32

Merged
merged 1 commit into from
Nov 22, 2024
Merged

chore: save payment info in vss #32

merged 1 commit into from
Nov 22, 2024

Conversation

EthanYuan
Copy link
Collaborator

@EthanYuan EthanYuan commented Nov 18, 2024 •
edited
Loading

  • save payment info in vss
  • use last_update as version

@EthanYuan EthanYuan requested review from jjyr and duanyytop November 18, 2024 02:01
@EthanYuan EthanYuan marked this pull request as ready for review November 20, 2024 08:57
@EthanYuan EthanYuan requested a review from Flouse November 20, 2024 08:58
@Flouse Flouse requested a review from ShookLyngs November 20, 2024 09:14
@jjyr jjyr merged commit 404df95 into utxostack:develop Nov 22, 2024
9 checks passed
@duanyytop
Copy link
Collaborator

duanyytop commented Nov 25, 2024 •
edited
Loading

Should this PR also implement the function get_activity of mutiny-node to obtain data from VSS?

@EthanYuan
Copy link
Collaborator Author

Should this PR also implement the function get_activity of mutiny-node to obtain data from VSS?

As I understand it, any data is obtained locally, not directly from vss. vss is simply a synchronization mechanism.

@duanyytop
Copy link
Collaborator

duanyytop commented Nov 25, 2024 •
edited
Loading

What should I do if I want to get the same Lightning activities from the VSS in multi-devices?

The test result is that the Lightning activities of the PC browser cannot be accessed in the mobile browser for the same account. The activities can only be stored in the PC browser indexedDB.

@duanyytop
Copy link
Collaborator

Discussion conclusion: the v1.10.10 of the mutiny-wasm doesn't include this PR and I will release v1.10.11 to verify again.

@duanyytop
Copy link
Collaborator

duanyytop commented Nov 25, 2024 •
edited
Loading

After testing, this feature works on v1.10.11

@EthanYuan EthanYuan deleted the save-payment-info branch January 9, 2025 03:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jjyr jjyr jjyr approved these changes

@duanyytop duanyytop Awaiting requested review from duanyytop

@Flouse Flouse Awaiting requested review from Flouse

@ShookLyngs ShookLyngs Awaiting requested review from ShookLyngs

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@EthanYuan @duanyytop @jjyr