Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support dynamic CKB fee rate #17

Merged
merged 1 commit into from
Apr 11, 2024

Conversation

yangby-cryptape
Copy link
Contributor

No description provided.

@yangby-cryptape
Copy link
Contributor Author

This JSON-RPC method is unreasonable, do NOT use it directly.

If someone sent a large-fee transaction, even all blocks are nearly empty, 1000 is enough, the dynamic fee rate API will still return a large number.

@yangby-cryptape
Copy link
Contributor Author

Maybe we could merge it for temporary use, before a better solution came.

@Flouse Flouse linked an issue Apr 4, 2024 that may be closed by this pull request
@Flouse Flouse requested a review from EthanYuan April 4, 2024 09:18
Flouse
Flouse previously approved these changes Apr 4, 2024
src/cli/mod.rs Outdated Show resolved Hide resolved
src/cli/mod.rs Outdated Show resolved Hide resolved
src/cli/mod.rs Outdated Show resolved Hide resolved
@yangby-cryptape yangby-cryptape force-pushed the feature/dynamic-fee-rate branch from c6ddaaf to 03bd8ff Compare April 10, 2024 18:02
@yangby-cryptape yangby-cryptape marked this pull request as ready for review April 11, 2024 00:02
@yangby-cryptape yangby-cryptape added this pull request to the merge queue Apr 11, 2024
Merged via the queue into master with commit 5f9bbc8 Apr 11, 2024
5 checks passed
@yangby-cryptape yangby-cryptape deleted the feature/dynamic-fee-rate branch April 11, 2024 08:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support dynamic CKB fee rate when send CKB transactions.
3 participants