Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Polish localization updates #6164

Merged
merged 1 commit into from
Apr 1, 2024

Conversation

mavethee
Copy link
Contributor

@mavethee mavethee commented Feb 29, 2024

Adds:

  • QEMULauncher string,
  • iOS permission strings,
  • Remove duplicates (?).

Improves:

  • Translation for new features,
  • Fix comments and eventual typos.

@mavethee mavethee force-pushed the polish-locale-utm-4.5-not-visionOS-yet branch 4 times, most recently from 37b3746 to 81843a5 Compare March 2, 2024 09:23
@mavethee
Copy link
Contributor Author

mavethee commented Mar 2, 2024

...aaaaand I have no clue why it fails apparently 🤡

@mavethee mavethee force-pushed the polish-locale-utm-4.5-not-visionOS-yet branch from 81843a5 to f1f56ca Compare March 2, 2024 11:00
Copy link
Contributor

@MMP0 MMP0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like you’re manually adding the files, but .strings files need to be compiled, so just placing them won’t get them localized.

To link to the Xcode project, you must check File Inspector > Localization > Polish on the right sidebar.

Sidebar Sidebar

If a dialog appears, select “Use file”.

Dialog Dialog

Platform/pl.lproj/Localizable.strings Outdated Show resolved Hide resolved
Platform/iOS/pl.lpoj/Info-RemotePlist.strings Outdated Show resolved Hide resolved
Platform/iOS/pl.lpoj/InfoPlist.strings Outdated Show resolved Hide resolved
@mavethee mavethee force-pushed the polish-locale-utm-4.5-not-visionOS-yet branch from f1f56ca to a7dfb19 Compare March 3, 2024 11:06
@mavethee
Copy link
Contributor Author

mavethee commented Mar 3, 2024

@MMP0 And that's it? I don't use Xcode sooo yeah, so far all strings I wrote were fine displaying fine, but yeah I don't own an iOS device to check or the AVP. After 'using file' on Polish strings, what needs to be done?

@mavethee mavethee closed this Mar 3, 2024
@mavethee mavethee deleted the polish-locale-utm-4.5-not-visionOS-yet branch March 3, 2024 16:05
@mavethee mavethee restored the polish-locale-utm-4.5-not-visionOS-yet branch March 3, 2024 16:05
@mavethee mavethee reopened this Mar 3, 2024
@mavethee mavethee force-pushed the polish-locale-utm-4.5-not-visionOS-yet branch from a7dfb19 to 654bb2c Compare March 3, 2024 16:12
@mavethee
Copy link
Contributor Author

mavethee commented Mar 3, 2024

Okay never mind, all it take to upload Xcode file 🤦🏻
Closing PR was my mistake as wanted to rename branch.
@MMP0 Can you review if you have any more issues to point out?
@osy would it be possible to merge it with stable release as it contains most recent changes in 4.5.x?

@mavethee mavethee requested a review from MMP0 March 3, 2024 16:16
@osy osy force-pushed the polish-locale-utm-4.5-not-visionOS-yet branch from 654bb2c to ddb967f Compare April 1, 2024 03:05
@osy osy merged commit 077cdbe into utmapp:main Apr 1, 2024
1 of 12 checks passed
@mavethee mavethee deleted the polish-locale-utm-4.5-not-visionOS-yet branch April 1, 2024 07:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants