package_mac.sh: fix fallback to hdiutil
#6118
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can you use the square bracket syntax to be consistent with the rest of the script? Then squash and force push? Thanks |
reidpr
force-pushed
the
package_mac_if
branch
from
7f67ae0
to
c9c21d8
Compare
|
Thanks. I can’t use square brackets because we’re testing the result of a command, rather than a conditional, but I can remove the parentheses entirely. Squashed and force-pushed. |
|
Makes sense, thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prior to this PR, if the test for
appimgon line 118 failed, the script would immediately exit (because ofset -eon line 3), without running the test on line 119. I.e., the script would just stop, producing neither a.dmgnor an error message.This PR moves the test into a subshell in the
if, and now the intendedhdiutilfallback works.