Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add parameter to select Xbox or PS4 mappings #77

Merged

Conversation

nstiurca
Copy link
Contributor

This implements feature request #76

@nstiurca
Copy link
Contributor Author

I could only test this locally with PS4 controller, so someone needs to verify that everything still works OK with Xbox controller.

@jack-oquin
Copy link
Member

Looks good to me after a cursory review. Thanks for defining constants for the controls.

Let us know when it's been tested with the other controller.

@nstiurca
Copy link
Contributor Author

I got my hands on an Xbox controller, and it seems to be working all right.

It looks like on Xbox controller, it uses the right thumbstick left/right for turning. I was using left thumb stick for both speed and turn on the PS4 joystick bindings. I guess I should change it for consistency?

@jack-oquin
Copy link
Member

I'm not up to speed on those devices. Do whatever seems best to you.

Thanks!

@nstiurca
Copy link
Contributor Author

Ok, then I would leave this PR it as-is. For whoever was already using this node, there should be no behavioral change whatsoever. For me, I have the exact same functionality with controls slightly better suited to my liking.

@jack-oquin
Copy link
Member

Sure. If anyone wants the other behavior, we can add it as an option.

@jack-oquin jack-oquin merged commit ebad853 into utexas-bwi:master Aug 26, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants