Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UI doesn't provide option to enter inputs of Generic datatype in a workflow #192

Open
pbsudharsan opened this issue Nov 25, 2020 · 4 comments
Labels
bug Something isn't working
Milestone

Comments

@pbsudharsan
Copy link

pbsudharsan commented Nov 25, 2020

Summary
UI doesn't have the option to choose input directory when the input is of Generic data type.

What is the current bug behavior?
UI doesn't have the option to enter/choose the name of the input file of Generic datatype .

What is the expected correct behavior?

Ability to choose the stored files of generic data type.

Steps to reproduce
Create a new plugin with a input of type generic datatype. If you try to access the same plugin in workflow window , UI doesn't have the option to enter/choose the name of the input file.

Relevant screenshots and/or logs
Screenshot from 2020-11-25 12-38-06
Screenshot from 2020-11-25 12-38-48

(Insert screenshots or paste any relevant logs - please use code blocks (```) to format console output,
logs, and code as it's very hard to read otherwise.)

Environment info

(WIPP version, web browser, deployment info)
Web browser : Google chrome
Deployment : http://wipp-ui.ci.aws.labshare.org/

CC @Nicholas-Schaub @sunnielyu

@pbsudharsan pbsudharsan added the bug Something isn't working label Nov 25, 2020
@MyleneSimon
Copy link
Collaborator

Just took a look, it seems that the handling of the generic data type is missing in the workflow detail component. The fix should be easy, but I am unsure about which version you are working with: I see 3.1.0 in the footer, but this version has been released yet and would include SSO, which I don't see here.
@mohamedOuladi can you provide some insight about the version that is deployed on CI?

@mohamedOuladi
Copy link
Collaborator

@MyleneSimon The version deployed on CI is indeed 3.1.0 but it's not really the same as the one you have released. The instance deployed is the refactored WIPP-frontend from my fork (doesn't include SSO yet) and I had to upgrade the version to follow the semantic versioning convention per Sunny's request. Thank you for spotting the issue with the workflow detail component, I will work on the fix and redeploy on our CI.

@MyleneSimon
Copy link
Collaborator

@mohamedOuladi sounds good, let me know if you need any help for the fix

@mohamedOuladi
Copy link
Collaborator

Issue was fixed in the wipp library.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants