Feature/issue191 wipp library refactor angular upgrade #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
FYI: I disabled inline editor library because it's causing issues with angular 9. We might need to look into an alternative solution to give the user the ability to modify collections' names. |
sunnielyu
requested changes
Feb 9, 2021
.../wipp-frontend-lib/src/lib/generic-data/generic-data-detail/generic-data-detail.component.ts
Outdated
Show resolved
Hide resolved
.../wipp-frontend-lib/src/lib/generic-data/generic-data-detail/generic-data-detail.component.ts
Outdated
Show resolved
Hide resolved
.../wipp-frontend-lib/src/lib/generic-data/generic-data-detail/generic-data-detail.component.ts
Outdated
Show resolved
Hide resolved
.../wipp-frontend-lib/src/lib/generic-data/generic-data-detail/generic-data-detail.component.ts
Outdated
Show resolved
Hide resolved
.../wipp-frontend-lib/src/lib/generic-data/generic-data-detail/generic-data-detail.component.ts
Outdated
Show resolved
Hide resolved
projects/wipp-frontend-lib/src/lib/generic-data/generic-data-new/generic-data-new.component.ts
Outdated
Show resolved
Hide resolved
...nd-lib/src/lib/stitching-vector/stitching-vector-detail/stitching-vector-detail.component.ts
Outdated
Show resolved
Hide resolved
projects/wipp-frontend-lib/src/lib/dynamic-content/dynamic-content.component.ts
Outdated
Show resolved
Hide resolved
projects/wipp-frontend-lib/src/lib/dynamic-content/dynamic-content.component.ts
Outdated
Show resolved
Hide resolved
sunnielyu
approved these changes
Feb 11, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Related issues
usnistgov#191 usnistgov#191
usnistgov#192 usnistgov#192
usnistgov#184 usnistgov#184