-
Notifications
You must be signed in to change notification settings - Fork 183
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Hotfix/refactor duplicates #2079
Conversation
cb5160c
to
4d70acf
Compare
This may not be need and is related to a bug in the behavior of metaschema-java not conforming to the Metaschema spec and processiong behavior for two independent inline assembly definitions still being independent despite the same identical local name. See metaschema-framework/metaschema-java#259 for more details. |
it may not be needed but it will also improve type generation and json-schema quality downstream, by re-using two seperate duplicate definitions which define the same thing |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These are unacceptable changes as proposed .
- NIST does not accept schemas not developed by NIST (see https://raw.githubusercontent.com/metaschema-framework/metaschema/refs/heads/develop/schema/xml/metaschema.xsd">)
- The extend of proposed changes is not justified by the implied hotfix for a pair of clashing constraints
4d70acf
to
55361de
Compare
rolled the schema change back, the schema change is not needed for the hotfix |
c7b12d1
to
5e85020
Compare
Closing, this, we can fix these issues upstream in metaschema java |
Committer Notes
naming conflicts in the metaschema cause errors in java model generation. this refactoring of models allows for validation use the metaschema validate-content command to correctly run
All Submissions:
By submitting a pull request, you are agreeing to provide this contribution under the CC0 1.0 Universal public domain dedication.
(For reviewers: The wiki has guidance on code review and overall issue review for completeness.)
Changes to Core Features: