Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hotfix/refactor duplicates #2079

Closed

Conversation

wandmagic
Copy link
Collaborator

@wandmagic wandmagic commented Nov 22, 2024

Committer Notes

naming conflicts in the metaschema cause errors in java model generation. this refactoring of models allows for validation use the metaschema validate-content command to correctly run

All Submissions:

By submitting a pull request, you are agreeing to provide this contribution under the CC0 1.0 Universal public domain dedication.

(For reviewers: The wiki has guidance on code review and overall issue review for completeness.)

Changes to Core Features:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your core changes, as applicable?
  • Have you included examples of how to use your new feature(s)?
  • Have you updated all OSCAL website and readme documentation affected by the changes you made? Changes to the OSCAL website can be made in the docs/content directory of your branch.

@wandmagic wandmagic requested a review from a team as a code owner November 22, 2024 13:17
@aj-stein-gsa
Copy link
Contributor

This may not be need and is related to a bug in the behavior of metaschema-java not conforming to the Metaschema spec and processiong behavior for two independent inline assembly definitions still being independent despite the same identical local name. See metaschema-framework/metaschema-java#259 for more details.

@wandmagic
Copy link
Collaborator Author

This may not be need and is related to a bug in the behavior of metaschema-java not conforming to the Metaschema spec and processiong behavior for two independent inline assembly definitions still being independent despite the same identical local name. See metaschema-framework/metaschema-java#259 for more details.

it may not be needed but it will also improve type generation and json-schema quality downstream, by re-using two seperate duplicate definitions which define the same thing

Copy link
Contributor

@iMichaela iMichaela left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These are unacceptable changes as proposed .

  1. NIST does not accept schemas not developed by NIST (see https://raw.githubusercontent.com/metaschema-framework/metaschema/refs/heads/develop/schema/xml/metaschema.xsd">)
  2. The extend of proposed changes is not justified by the implied hotfix for a pair of clashing constraints

@wandmagic
Copy link
Collaborator Author

These are unacceptable changes as proposed .

  1. NIST does not accept schemas not developed by NIST (see https://raw.githubusercontent.com/metaschema-framework/metaschema/refs/heads/develop/schema/xml/metaschema.xsd">)
  2. The extend of proposed changes is not justified by the implied hotfix for a pair of clashing constraints

rolled the schema change back, the schema change is not needed for the hotfix

@wandmagic wandmagic force-pushed the hotfix/refactor-duplicates branch 2 times, most recently from c7b12d1 to 5e85020 Compare November 23, 2024 16:26
@wandmagic
Copy link
Collaborator Author

Closing, this, we can fix these issues upstream in metaschema java

@wandmagic wandmagic closed this Nov 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants