Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix location in bootstrap code #2090

Merged
merged 1 commit into from
Dec 8, 2024
Merged

Conversation

sungshik
Copy link
Contributor

@sungshik sungshik commented Dec 6, 2024

I was using module Bootstrap (in the context of #2083), but the generated parser wasn't written to the expected/existing file. Thought I'd fix it in this separate PR first (i.e., there are some other unexpected bootstrap diffs in #2083, but their severity/timeline-to-fix isn't clear yet).

Copy link

codecov bot commented Dec 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 49%. Comparing base (3329554) to head (6652bc0).
Report is 4 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##              main   #2090   +/-   ##
=======================================
  Coverage       49%     49%           
+ Complexity    6328    6319    -9     
=======================================
  Files          666     666           
  Lines        59687   59687           
  Branches      8670    8670           
=======================================
+ Hits         29610   29611    +1     
- Misses       27839   27841    +2     
+ Partials      2238    2235    -3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@DavyLandman
Copy link
Member

I'm not familiar with this code enough to know if this is the right fix. @jurgenvinju would be better for this.

My hunch would be: are we sure that the rascalHome variable shouldn't just point to this sub-directory?

@sungshik
Copy link
Contributor Author

sungshik commented Dec 6, 2024

I don't know for sure either. There is some precedent in the same module, though:

gr = getRascalGrammar(rascalHome + "src/org/rascalmpl/library/lang/rascal/syntax/Rascal.rsc");

gr = getRascalGrammar(rascalHome + "src/org/rascalmpl/library/lang/rascal/syntax/Rascal.rsc");

grammarToJavaAPI(rascalHome + "src/org/rascalmpl/ast", "org.rascalmpl.ast", g);

@jurgenvinju
Copy link
Member

It's whatever we need it to be. So thanks!

@jurgenvinju jurgenvinju merged commit bea8828 into main Dec 8, 2024
7 checks passed
@jurgenvinju jurgenvinju deleted the fix-location-in-bootstrap-code branch December 8, 2024 15:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants