Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/remove auto disambiguation #2075

Merged
merged 3 commits into from
Dec 17, 2024

Conversation

PieterOlivier
Copy link
Contributor

@PieterOlivier PieterOlivier commented Nov 11, 2024

This PR removes the automatic disambiguation of error trees when allowRecovery=true but allowAmbiguity=false.

Note that in this case a separate check is needed for 'regular' ambiguities (which are not allowed).

Copy link

codecov bot commented Nov 11, 2024

Codecov Report

Attention: Patch coverage is 36.36364% with 14 lines in your changes missing coverage. Please review.

Project coverage is 49%. Comparing base (79be4a0) to head (40b1226).
Report is 109 commits behind head on feat/error-recovery.

Files with missing lines Patch % Lines
src/org/rascalmpl/library/util/ErrorRecovery.java 40% 6 Missing and 6 partials ⚠️
...g/rascalmpl/values/RascalFunctionValueFactory.java 0% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@                  Coverage Diff                  @@
##             feat/error-recovery   #2075   +/-   ##
=====================================================
- Coverage                     49%     49%   -1%     
+ Complexity                  6610    6607    -3     
=====================================================
  Files                        685     685           
  Lines                      61145   61152    +7     
  Branches                    8850    8852    +2     
=====================================================
- Hits                       30253   30244    -9     
- Misses                     28691   28701   +10     
- Partials                    2201    2207    +6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@PieterOlivier PieterOlivier mentioned this pull request Nov 12, 2024
@PieterOlivier PieterOlivier merged commit c460e2c into feat/error-recovery Dec 17, 2024
6 of 7 checks passed
@PieterOlivier PieterOlivier deleted the feat/remove-auto-disambiguation branch December 17, 2024 09:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants