Fixed @<column> requirement implementation #2069
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2069 +/- ##
=======================================
Coverage 49% 49%
- Complexity 6302 6311 +9
=======================================
Files 664 664
Lines 59635 59635
Branches 8648 8648
=======================================
+ Hits 29471 29483 +12
+ Misses 27950 27932 -18
- Partials 2214 2220 +6 ☔ View full report in Codecov by Sentry. |
toinehartman
approved these changes
Nov 4, 2024
src/org/rascalmpl/library/lang/rascal/tests/concrete/AtColumnRequirement.rsc
Outdated
Show resolved
Hide resolved
|
@PieterOlivier can you add an description of the bug it fixes to the GH description? |
DavyLandman
approved these changes
Nov 5, 2024
|
Super! We need the inverse operator too if this will ever be useful for disambiguation. So at least |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Rascal "@" syntax column requirement was implemented incorrectly. Filtering was done if the current column was the expected column while it should have been the other way around.
This PR fixes this issue.