Fixed size inconsistency between allocating and enlarging #2062
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DavyLandman
approved these changes
Oct 24, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## feat/error-recovery #2062 +/- ##
=====================================================
- Coverage 49% 49% -1%
+ Complexity 6590 6580 -10
=====================================================
Files 685 685
Lines 61146 61146
Branches 8849 8849
=====================================================
- Hits 30217 30193 -24
- Misses 28723 28745 +22
- Partials 2206 2208 +2 ☔ View full report in Codecov by Sentry. |
toinehartman
approved these changes
Oct 24, 2024
Draft
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In some rare cases (after error recovery), the
propagatedPrefixesbitset was too small. This was caused by a difference in size between allocating a new bitset and enlarging the bitset.This is solved in this PR.