Implement basic error recovery #2020
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ree non-terminals
…arser implementation
Sometimes recovery nodes start before the current location where the parser failed to continue. Since the parser works with a short queue of schedulede TODO's around the current cursor, we might end up outside of this queue when recovering. This breaks several unspecified invariants of the SGTBF implementations. For now I added a detection that a recovery node is to be planned before the currently retained history and filter that recovery node. The next step will be to make sure backtracking over the current location is made possible.
…er input locations)
… because the next parser loop iteration always wants to advance one character
…e version of Rascal and (b) the edit command is wired to the edit IDEService
…t in the scheme by copyinhthe contents to a tmp file
sungshik
reviewed
Sep 4, 2024
There was a problem hiding this comment.
Oh that's an impressive amount of work! I'm very curious to see all this working in VS Code down the line 🙂 For now, I think none of my comments are blocking. Lots of minor nits, and other than that, just a bunch of questions about certain implementation choices and small suggestions. In general, the approach looks sound to me.
DavyLandman
reviewed
Sep 6, 2024
src/org/rascalmpl/library/lang/rascal/tests/recovery/BasicRecoveryTests.rsc
Outdated
Show resolved
Hide resolved
src/org/rascalmpl/library/lang/rascal/tests/recovery/BasicRecoveryTests.rsc
Outdated
Show resolved
Hide resolved
src/org/rascalmpl/parser/uptr/recovery/CaseInsensitiveLiteralMatcher.java
Outdated
Show resolved
Hide resolved
Closed
Draft
toinehartman
pushed a commit
that referenced
this pull request
Oct 16, 2024
Implement basic error recovery
toinehartman
pushed a commit
that referenced
this pull request
Oct 21, 2024
Implement basic error recovery
toinehartman
pushed a commit
that referenced
this pull request
Oct 21, 2024
Implement basic error recovery
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements a basic error recoverer and fixes some issues in the existing error recovery support code.
The new recoverer is called "ToTokenRecoverer" and tries to find a suitable continuation token when recovering from a parse error.
When the parser detects a parse error, the error recover skips part of the input and reduces the production that is currently being recognized. It then let the parser continue.
To determine which part of the input to skip, the recoverer tries to find a literal that could terminate the current production or a literal that could start the next sibling production. If such a literal is found, all input until after the "end" literal or all input until before the "next" literal will be skipped and parsing will continue.