Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improved the licenses generated into our shaded jar #2016

Merged
merged 1 commit into from
Aug 27, 2024

Conversation

DavyLandman
Copy link
Member

@DavyLandman DavyLandman commented Aug 22, 2024

This PR introduces the following changes:

  • defined our license in the pom.xml file. I had to say only bsd2, as also saying epl1 would be interpreted that our users can pick either license for the whole code)
  • the NOTICE file of all shaded dependencies are properly merged
  • the LICENSE file of all shaded dependencies are properly merged (future work: it looked like at some point the tutor did that, but that is currently not working)
  • a new licenses/ folder is generated with all the downstream licenses, and a xml with a list of all the dependencies and their licenses is stored in the licenses.xml file in the jar.

Copy link

codecov bot commented Aug 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 49%. Comparing base (c56a6fd) to head (354e452).
Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##              main   #2016   +/-   ##
=======================================
- Coverage       49%     49%   -1%     
- Complexity    6298    6301    +3     
=======================================
  Files          664     664           
  Lines        59626   59626           
  Branches      8646    8646           
=======================================
- Hits         29476   29472    -4     
- Misses       27939   27942    +3     
- Partials      2211    2212    +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jurgenvinju
Copy link
Member

jurgenvinju commented Aug 27, 2024

This looks great.

@jurgenvinju jurgenvinju merged commit 0a7dcdb into main Aug 27, 2024
7 checks passed
@DavyLandman
Copy link
Member Author

Thanks!

There is already code for listing the dependencies;

The mvn plugin uses the <license> field of all the pom dependencies, and all our dependencies had it defined (except for vallang, where I've now added it).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants