-
Notifications
You must be signed in to change notification settings - Fork 77
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
rewrote squeeze in Rascal with reified classes #2002
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2002 +/- ##
=======================================
Coverage 49% 49%
- Complexity 6309 6322 +13
=======================================
Files 664 664
Lines 59633 59584 -49
Branches 8648 8640 -8
=======================================
+ Hits 29486 29497 +11
+ Misses 27938 27877 -61
- Partials 2209 2210 +1 ☔ View full report in Codecov by Sentry. 🚨 Try these New Features:
|
…e new one is still broken on unicode for a different reason
…, but the new one is still broken on unicode for a different reason" This reverts commit 58b2283.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
This now also fixes the other issues identified in #2009 and some more because of better testing (especially now character escaping works the same for literals, ci-iterals and character classes). The |
@PaulKlint Davy has looked at it and the PR I merged into this was also reviewed already. Many more tests were added; I think the compiler will not have issue with those. |
it has been, just not released a new version of vallang yet. |
Check! |
type[..]
constructor that was resolved.#[a-z]
character class notation instead of strings for the second parameter of squeezesqueeze
function.