Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove black color from Rascal prompt #1908

Merged
merged 1 commit into from
Jan 15, 2024

Conversation

linuswagner
Copy link

@linuswagner linuswagner commented Jan 15, 2024

Fixes #1806

By removing the color from the prompt, making it only bold, the shell can decide about coloring, which should allow the prompt to be always readable

@linuswagner
Copy link
Author

Likely fails, because it works on top of the current head of the repo (d962e8e) which also fails tests

@jurgenvinju jurgenvinju merged commit 5b6c301 into usethesource:main Jan 15, 2024
2 of 3 checks passed
@jurgenvinju
Copy link
Member

Thanks @linuswagner ; we'll see if the tests run now due to the fixes on the main branch.

@DavyLandman
Copy link
Member

DavyLandman commented Jan 15, 2024

It's not actually black, it's the ANSI color code for black, that a theme redefines for what it means on this specific terminal. Like dark themes and light themes map that same color code to a different color.

Could you run some tests on different themes to see how it behaves?

@DavyLandman
Copy link
Member

DavyLandman commented Jan 16, 2024

Here is one to test out:

echo -e "\033[30;1m rascal>"

And testing it, depending on your color scheme, it's indeed hard to read. It might mean that the person who wrote the prompt codes, was working on a terminal with a light color scheme.

So yes, I think this is the right fix 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Console not displaying correctly through Maven
3 participants