Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

xml attribute locations #1893

Draft
wants to merge 6 commits into
base: main
Choose a base branch
from
Draft

xml attribute locations #1893

wants to merge 6 commits into from

Conversation

jurgenvinju
Copy link
Member

  • Using jsoup 1.17.1 which can track attribute locations
  • minor refactoring for clarity

@jurgenvinju jurgenvinju mentioned this pull request Nov 27, 2023
Closed
DavyLandman
DavyLandman approved these changes Nov 27, 2023
View reviewed changes
Copy link
Member

@DavyLandman DavyLandman left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, feel free to merge this after you've got the build to succeed.

would be nice if we could add some tests? but otherwise: all good.

@jhy jhy mentioned this pull request Nov 28, 2023
Closed
@jurgenvinju jurgenvinju marked this pull request as draft November 28, 2023 09:36
@jurgenvinju
Copy link
Member Author

jurgenvinju commented Nov 28, 2023 •
edited
Loading

Thanks!

  • Found a bug in the jsoup implementation, so I'm waiting for that fix and a release.
  • If we ever want to lift these node to parse trees we also need the locations of the names of the attributes. So I'm thinking to extend the srcs map to map[str label, tuple[loc name, loc val] src]

@jurgenvinju
Copy link
Member Author

See jhy/jsoup#1933

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DavyLandman DavyLandman DavyLandman approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jurgenvinju @DavyLandman