Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added some documentation to lang::java #1890

Merged
merged 6 commits into from
Dec 7, 2023

Conversation

linuswagner
Copy link

@linuswagner linuswagner commented Nov 20, 2023

No change to functionality done.

  • added documentation to some of the lang::java functions
  • deprecated getMethodSignature
  • removed classPath from createM3FromMavenProject (unused parameter)
  • fixed the deprecated tag in the Node file (lower case needed)

@jurgenvinju can you have a look if my descriptions are useful?
I also added references to other parts, do they work like I thought?

Also, there are some functions in AST and Core where I don't know what to write, because my understanding of Rascal/Java domain is not deep enough.
If someone wants to contribute while we're at it, feel free

Copy link

codecov bot commented Nov 20, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (d85f086) 49% compared to head (006c815) 49%.
Report is 3 commits behind head on main.

❗ Current head 006c815 differs from pull request most recent head f47a44c. Consider uploading reports for the commit f47a44c to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##              main   #1890   +/-   ##
=======================================
  Coverage       49%     49%           
- Complexity    6158    6163    +5     
=======================================
  Files          661     661           
  Lines        58695   58695           
  Branches      8546    8546           
=======================================
+ Hits         28939   28941    +2     
  Misses       27559   27559           
+ Partials      2197    2195    -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@jurgenvinju jurgenvinju left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @linuswagner; these changes look exactly like they should.

@jurgenvinju jurgenvinju merged commit 6c05758 into usethesource:main Dec 7, 2023
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants