Remove conditionals from the symbol when making the hole for concrete syntax #1878
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… syntax This fixes #1877 which unearthed that the symbolAST2SymbolConstructor behaved differently
Codecov Report
@@ Coverage Diff @@
## main #1878 +/- ##
=======================================
Coverage 49% 49%
- Complexity 6155 6156 +1
=======================================
Files 660 660
Lines 58668 58668
Branches 8543 8543
=======================================
+ Hits 28918 28921 +3
+ Misses 27561 27557 -4
- Partials 2189 2190 +1 |
|
@jurgenvinju helped write this code and review it, so the test have passed, merging this and creating a bugfix release. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #1877 which unearthed that the symbolAST2SymbolConstructor behaved differently