Fix groupByNameAndOrganization resolver errors when group not found #3800
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
General Checklist
Database Migrations
When attempting to load a group by name and org ID, and the group either doesn't exist, or is not a part of the organization, AND the
members
field is requested, a cryptic error would be thrown:This is because the resolver returns groupS but the schema expects a single group. Returning an empty array still calls the members resolver, which can't get any information for an
undefined
group and fails.This PR changes the return value to be a single group, and throws a normal
GroupNotFoundError
.This was broken before the keycloak upgrade refactor but the base branch is that to help with merge conflicts. Can wait to merge after keycloak upgrade.