Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Styled-components + TS w/ eslint #104

Merged
merged 21 commits into from
Mar 23, 2023
Merged

Styled-components + TS w/ eslint #104

merged 21 commits into from
Mar 23, 2023

Conversation

DaveDarsa
Copy link
Contributor

@DaveDarsa DaveDarsa commented Feb 24, 2023

  • Styling is now done with styled-components.
  • Some components have been Typescriptified, but in the long term we need proper types from the backend.
  • Custom linter + typescript configuration added, and it also lints js files less strictly.
  • some visual fixes
  • more types for used packages

@DaveDarsa
Copy link
Contributor Author

note: it's possible now to yarn dev with hardcoded env vars, proper fix coming next

@DaveDarsa
Copy link
Contributor Author

To enable runtime configuration, it is crucial for the Next app to opt out of static optimization, with that fix applied, now both yarn dev with build time env vars and docker-compose runtime env vars produce the desired effect

@tobybellwood
Copy link
Member

Agreement to finalise this PR at the dep updates only, and handle styled components and TypeScript in a new PR.

@DaveDarsa DaveDarsa mentioned this pull request Feb 28, 2023
@DaveDarsa
Copy link
Contributor Author

@tobybellwood I made a PR with just the dependency update part from this one at #106

I'll continue working on this branch for styled-components and typescript integration

@DaveDarsa DaveDarsa changed the title Partial dep update Storybook+TS Mar 1, 2023
@DaveDarsa DaveDarsa changed the title Storybook+TS Storybook+TS w/ eslint Mar 1, 2023
@DaveDarsa DaveDarsa changed the title Storybook+TS w/ eslint Styled-components + TS w/ eslint Mar 1, 2023
@DaveDarsa DaveDarsa marked this pull request as ready for review March 6, 2023 11:30
@DaveDarsa
Copy link
Contributor Author

@tobybellwood the summary of this pr:

  • Styling is now done with styled-components.
  • Some components have been Typescriptified, but in the long term we need proper types from the backend.
  • Custom linter + typescript configuration added, and it also lints js files less strictly.
  • some visual fixes
  • more types for used packages

@DaveDarsa
Copy link
Contributor Author

@tobybellwood PR is ready to be merged, the issue when running certain tasks comes from the backend as far as I'm aware

@tobybellwood
Copy link
Member

hey @rocketeerbkw - any chance you can cast your eyes over the typescript and lint config to see if you have any thoughts? The rewrite is like-for-like and we've functional tested it ok, but just wanted to rubber duck the settings if necessary

src/webpack.shared-config.js Outdated Show resolved Hide resolved
package.json Outdated Show resolved Hide resolved
package.json Show resolved Hide resolved
package.json Outdated Show resolved Hide resolved
package.json Outdated Show resolved Hide resolved
tsconfig.json Show resolved Hide resolved
tsconfig.json Outdated Show resolved Hide resolved
tsconfig.json Show resolved Hide resolved
tsconfig.json Outdated Show resolved Hide resolved
.eslintrc.js Show resolved Hide resolved
@DaveDarsa DaveDarsa requested a review from rocketeerbkw March 22, 2023 16:15
Copy link
Member

@tobybellwood tobybellwood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've tested through this a fair bit, and the comments have been addressed (either here, or slated for follow-up). Approving here, and merging, will make more tweaks in later PRs

@tobybellwood tobybellwood dismissed rocketeerbkw’s stale review March 23, 2023 01:48

Changes requested have either been incorporated or slated for follow-up

@tobybellwood tobybellwood merged commit 57f0dd0 into main Mar 23, 2023
@tobybellwood tobybellwood deleted the partial-dep-update branch March 23, 2023 01:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants