-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Styled-components + TS w/ eslint #104
Conversation
DaveDarsa
commented
Feb 24, 2023
•
edited by tobybellwood
Loading
edited by tobybellwood
- Styling is now done with styled-components.
- Some components have been Typescriptified, but in the long term we need proper types from the backend.
- Custom linter + typescript configuration added, and it also lints js files less strictly.
- some visual fixes
- more types for used packages
note: it's possible now to yarn dev with hardcoded env vars, proper fix coming next |
To enable runtime configuration, it is crucial for the Next app to opt out of static optimization, with that fix applied, now both yarn dev with build time env vars and docker-compose runtime env vars produce the desired effect |
Agreement to finalise this PR at the dep updates only, and handle styled components and TypeScript in a new PR. |
@tobybellwood I made a PR with just the dependency update part from this one at #106 I'll continue working on this branch for styled-components and typescript integration |
@tobybellwood the summary of this pr:
|
@tobybellwood PR is ready to be merged, the issue when running certain tasks comes from the backend as far as I'm aware |
hey @rocketeerbkw - any chance you can cast your eyes over the typescript and lint config to see if you have any thoughts? The rewrite is like-for-like and we've functional tested it ok, but just wanted to rubber duck the settings if necessary |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've tested through this a fair bit, and the comments have been addressed (either here, or slated for follow-up). Approving here, and merging, will make more tweaks in later PRs
Changes requested have either been incorporated or slated for follow-up