Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update golang to 1.23 #405

Merged
merged 4 commits into from
Nov 17, 2024
Merged

chore: update golang to 1.23 #405

merged 4 commits into from
Nov 17, 2024

Conversation

tobybellwood
Copy link
Member

@tobybellwood tobybellwood commented Nov 14, 2024

This PR updates all usage of Go in the service to the latest major version available (1.23).

I've created an umbrella PR here to bring all the elements of the go update together - the actions, docker, makefile, go mod etc - it's really hard to manage them all via dependabot (without creating multiple PRs). Going forward, we will work in a scheduled PR for the Golang update every go release cycle. Given the inconsistencies between local versions, actions versions and upstream availability, we're opting for the most recent available version in the GitHub runner images (currently https://github.com/actions/runner-images/blob/main/images/ubuntu/Ubuntu2404-Readme.md) - which at Golang 1.23.2 is a patch release behind the current head.

I've also run a module update here (which may close some other PRs, too). This necessitated a license review for a couple of dependencies, which I've added to the local config here on review - again following the CNCF lead where possible and conducting a desktop assessment of any outliers.

I experimented with the fail_on_severity setting, but I feel that not seeing the vulnerabilities displayed below "critical" isn't enough information. Realistically, we're not in a place to be super-strict with vulnerabilities, but the intelligence provided here is valuable as part of the PR review process.

closes #402
closes #395
closes #380

Copy link
Member

@shreddedbacon shreddedbacon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Each of the individual pullrequests mentioned address parts, yet they all have problems with merging in isolation with one or so actions failing to pass due to a requirement of another pullrequest. It makes sense to try and consolidate updates like this.

We are also able to do single pullrequests that address just the version bump of Go across the actions, dockerfile, makefile in one, and then module dependency updates in another too, the two don't always have to be done at the same time.

@tobybellwood tobybellwood marked this pull request as ready for review November 17, 2024 22:33
@tobybellwood tobybellwood merged commit b4bff86 into main Nov 17, 2024
7 checks passed
@tobybellwood tobybellwood deleted the golang-123 branch November 17, 2024 23:06
@smlx
Copy link
Member

smlx commented Nov 18, 2024

I've also run a module update here (which may close some other PRs, too). This necessitated a license review for a couple of dependencies, which I've added to the local config here on review - again following the CNCF lead where possible and conducting a desktop assessment of any outliers.

This is the reason I asked about Lagoon licensing requirements the other day. We don't need to be as strict as the CNCF and only allowlist permissive licences. We can also allowlist e.g. MPL-2.0 and forget about having to individually specify MPL dependencies.

@tobybellwood
Copy link
Member Author

Yes, once we get further through the services, we can probably move to a centralised more permissive allowlist. For a couple of them that we want to really encourage reuse/adoption (this, machinery and maybe some tasks), we probably can be a little tighter on excluding copyleft and have per-repo exclusions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants