Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change: Refactored get project command, adds deploymentsDisabled & updated to use bools instead of int bools #297

Merged
merged 7 commits into from
Dec 5, 2023
Merged

Change: Refactored get project command, adds deploymentsDisabled & updated to use bools instead of int bools #297

merged 7 commits into from
Dec 5, 2023

Conversation

CGoodwin90
Copy link
Contributor

@CGoodwin90 CGoodwin90 commented Oct 26, 2023 •
edited
Loading

Checklist

  • Affected Issues have been mentioned in the Closing issues section
  • Documentation has been written/updated.
  • Changelog entry has been written

Refactors the get project command to utilize Machinery, includes deploymentsDisabled in the output and updates the autoIdle, factsUI, problemsUI and deploymentsDisabled fields to display true/false over 0/1.

Requires Machinery PR #uselagoon/machinery#27

closes #291

@CGoodwin90 CGoodwin90 marked this pull request as ready for review October 26, 2023 06:30
shreddedbacon
shreddedbacon approved these changes Dec 4, 2023
View reviewed changes
Copy link
Member

@shreddedbacon shreddedbacon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fix up the conflicts and this is good to go 🚀

@shreddedbacon shreddedbacon merged commit 9274b3f into main Dec 5, 2023
4 checks passed
@shreddedbacon shreddedbacon deleted the refactor_get_project branch December 5, 2023 01:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shreddedbacon shreddedbacon shreddedbacon approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Show deploymentsDisabled in get project
2 participants
@CGoodwin90 @shreddedbacon