Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change: Updates the router handler to handle panic on incorrect service #39

Merged
merged 1 commit into from
Apr 5, 2024
Merged

Change: Updates the router handler to handle panic on incorrect service #39

merged 1 commit into from
Apr 5, 2024

Conversation

CGoodwin90
Copy link
Contributor

Currently the http library panics on ServeHTTP when an incorrect service is provided. This reworks the router handler function to handle panics on incorrect service and display relevant messaging. Includes a basic test

@CGoodwin90 CGoodwin90 marked this pull request as ready for review April 3, 2024 03:07
tobybellwood
tobybellwood approved these changes Apr 5, 2024
View reviewed changes
Copy link
Member

@tobybellwood tobybellwood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice improvement, thanks!

@tobybellwood tobybellwood merged commit 09dccc7 into main Apr 5, 2024
3 checks passed
@tobybellwood tobybellwood deleted the handle_router_panic branch April 5, 2024 01:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tobybellwood tobybellwood tobybellwood approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@CGoodwin90 @tobybellwood