Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Core logic rewrite and refactor. #66

Merged
merged 13 commits into from
Feb 12, 2024
Merged

Core logic rewrite and refactor. #66

merged 13 commits into from
Feb 12, 2024

Conversation

bomoko
Copy link
Contributor

@bomoko bomoko commented Feb 7, 2024

The PR introduces some code reorganization to make future work simpler, as well as adds some new tests.

Changes introduced

  • Separates the gathering of facts from incoming unstructured types (i.e. configMap reads) from actually writing those facts. This was a single step before - but this is a change towards SRP.
  • Gets rid of "interface" type - thereby supporting better static type checking across the entire system.
  • Deprecates support for 'sbom' and 'image' types. The build-deploy tool only actually sends 'sbom-gz' and 'image-gz' types since we introduced compression. Supporting both paths introduces needless complexity.
  • Deprecates support for the 'direct' fact type introduced Feature/trivy parser facts #18 - this has been replaced by the 'direct.facts' and 'direct.problems' types
  • Because of previous deprecations above, we can, further, deprecate processing of non-binary payloads in general for non-typed/direct insights payloads.

@bomoko bomoko changed the title Code reorganization and adding tests Core logic rewrite and refactor. Feb 11, 2024
@bomoko bomoko requested a review from timclifford February 12, 2024 02:50
@timclifford
Copy link
Contributor

image

This PR gives me strong healing/cleansing vibes 😆

@bomoko bomoko merged commit b82f729 into main Feb 12, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants