-
Notifications
You must be signed in to change notification settings - Fork 36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added first set of texture file format tests #88
Added first set of texture file format tests #88
Conversation
AlexSchwank
commented
May 15, 2024
•
edited
Loading
edited
- JPEG, CMYK, 8-bit
- JPEG, RGB, 8-bit
- JPEG, Grayscale, 8-bit
- PNG, Grayscale 8-bit
- PNG, Grayscale, 16-bit
- PNG, RGB, 8-bit
- PNG, RGB, 16-bit
- PNG, RGB, 32-bit
I'll add the source PSD after the group has discussed if this is good to go. |
This looks great :) Would it would be possible to attach in a readme perhaps, a little snippet of code (Python? C++? doesn't really matter) to generate the color and grayscale strip for the top scanline? That would allow the construction of unit tests that procedurally generate the gradient, open the image file, and then do a variety of baseline metrics versus expected values. If the images were generated using photoshop tools, could I request that we generate the gradients procedurally instead? This would really help in tracing down one bit encoding errors that sometimes occur with formats like jpeg. |
hmm, lots of errors in like this Run usdchecker:
|
@jcowles Is there an error in the checker? It's reporting
but shaderDefs.usda isn't something originating with this PR. (Or I can't spot it) |
not sure what's happening there |
PixarAnimationStudios/OpenUSD#3055
|
I tried manually copying the relevant file, but it doesn't seem that easy to fix. We could lock usdchecker at v24.03 until this issue is resolved - I've set up the PR above. |
Thanks @pablode . Happy to lock the USD version to a specific one. |
@AlexSchwank mind merging main (or rebasing) into your branch and pushing again to this to get it to re-run usdchecker? (I tried just hitting re-run, but I think it's running against the version of main your branch is at) |