fix: update bounds on CarbonFrameBike #50
Conversation
beersandrew
commented
Jul 27, 2023
beersandrew
commented
- based on the issue described here: Object bounds of Bike and Elephant full assets fail to appear for some viewers #32
- got the asset from it's source: https://prefrontalcortex.de/labs/model-viewer/upload/CarbonFrameBike/
- converted with RealityConverter (this gave better bounds)
- ran usdfixbrokenpixarschemas
- fixed a few minor issues from usdchecker
- based on the issue described here: #32 - got the asset from it's source: https://prefrontalcortex.de/labs/model-viewer/upload/CarbonFrameBike/ - converted with RealityConverter (this gave better bounds) - ran usdfixbrokenpixarschemas - fixed a few minor issues from usdchecker
|
@hybridherbst do you happen to have the non usd form of https://github.com/usd-wg/assets/tree/main/full_assets/ElephantWithMonochord? I'd like to try converting it again to try to fix the bounds issues on it. |
|
Hi Andrew, you've got this marked as Draft ~ do you have further work you want to do on it before people review? |
@meshula My idea was to get both the CarbonFrameBike and the ElephantWithMonochord since they have similar problems in the same issue and could possibly close out that issue entirely. However, I'm happy to just do them one by one if you'd like |
|
one asset at a time makes sense to me, it would keep the commit history simple and focused on an asset at a time. |
|
Hi @beersandrew , did you apply fixes to the normal map texture readers by any chance ? Edit: Nvm :) I checked the file and can see that you have, thanks! |
Works for me, this is ready to be reviewed then |
|
@beersandrew the source files for both are in Unity (and exported with Unity's USD plugin), however that plugin still doesn't export bounds and binding APIs correctly. |
|
Confirmed with @hybridherbst this so good to go - merging |
|
Actually, there is a merge conflict @beersandrew would you mind updating from latest? |
@jcowles fixed |
|
Thankyousir! |
|
Nice to see! Looks good on this end. I hope someone can fix the Elephant at some point, as it's still wonky. |
I tried some frankenstein path of conversions with the elephant, from the repo usdz -> blender export as glb -> reality converter back to usdz, which fixes the bounds, however the animation gets lost since I can't import the animations into blender. I'll try some other paths this week to see if I can fix the elephant entirely |
