Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Update base image to AnalysisBase v25.2.27 #67

Open
wants to merge 1 commit into
base: dev
Choose a base branch
from

Conversation

matthewfeickert
Copy link
Member

@matthewfeickert matthewfeickert commented Sep 17, 2024

Resolves #66

  • Update the base image to gitlab-registry.cern.ch/atlas/athena/analysisbase:25.2.27 as the ROOT version is v6.32.02.
$ docker run --rm -ti gitlab-registry.cern.ch/atlas/athena/analysisbase:25.2.27 /bin/bash -c '. /release_setup.sh && root --version'
Configured GCC from: /opt/lcg/gcc/13.1.0-b3d18/x86_64-el9/bin/gcc
Configured AnalysisBase from: /usr/AnalysisBase/25.2.27/InstallArea/x86_64-el9-gcc13-opt
ROOT Version: 6.32.02
Built for linuxx8664gcc on Sep 12 2024, 00:46:44
From tags/v6-32-02@v6-32-02

@matthewfeickert matthewfeickert self-assigned this Sep 17, 2024
@matthewfeickert
Copy link
Member Author

cc @fengpinghu

* Update the base image to gitlab-registry.cern.ch/atlas/athena/analysisbase:25.2.27
  as the ROOT version is v6.32.02.
* Rebuild lock file as the CPython version has chaned to Python 3.11.
@matthewfeickert
Copy link
Member Author

Currently hitting a build error

#17 10.79 /tmp/pycolumnarprototype/src/ColumnarPrototype/Root/ColumnarEgammaCalibrationAndSmearingTool.cxx:166:17: error: cannot convert 'egEnergyCorr::Resolution::Variation' to 'egEnergyCorr::Scale::Variation'
#17 10.79   166 |                 m_currentResolutionVariation,
#17 10.79       |                 ^~~~~~~~~~~~~~~~~~~~~~~~~~~~
#17 10.79       |                 |
#17 10.79       |                 egEnergyCorr::Resolution::Variation
#17 10.79 In file included from /usr/AnalysisBase/25.2.27/InstallArea/x86_64-el9-gcc13-opt/src/PhysicsAnalysis/ElectronPhotonID/ElectronPhotonFourMomentumCorrection/ElectronPhotonFourMomentumCorrection/EgammaCalibrationAndSmearingTool.h:22,
#17 10.79                  from /tmp/pycolumnarprototype/src/ColumnarPrototype/ColumnarPrototype/ColumnarEgammaCalibrationAndSmearingTool.h:15,
#17 10.79                  from /tmp/pycolumnarprototype/src/ColumnarPrototype/Root/ColumnarEgammaCalibrationAndSmearingTool.cxx:11:
#17 10.79 /usr/AnalysisBase/25.2.27/InstallArea/x86_64-el9-gcc13-opt/src/PhysicsAnalysis/ElectronPhotonID/ElectronPhotonFourMomentumCorrection/ElectronPhotonFourMomentumCorrection/egammaEnergyCorrectionTool.h:419:38: note:   initializing argument 10 of 'double AtlasRoot::egammaEnergyCorrectionTool::getCorrectedEnergy(unsigned int, PATCore::ParticleDataType::DataType, PATCore::ParticleType::Type, double, double, double, double, double, RandomNumber, egEnergyCorr::Scale::Variation, egEnergyCorr::Resolution::Variation, egEnergyCorr::Resolution::resolutionType, double) const'
#17 10.79   419 |       egEnergyCorr::Scale::Variation scaleVar = egEnergyCorr::Scale::None,
#17 10.79       |       ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
#17 10.92 [ 25%] Building CXX object bindings/CMakeFiles/nanobind-static.dir/__/nanobind/src/nb_type.cpp.o
#17 11.42 gmake[2]: *** [ColumnarPrototype/CMakeFiles/ColumnarPrototypeLib.dir/build.make:90: ColumnarPrototype/CMakeFiles/ColumnarPrototypeLib.dir/Root/ColumnarEgammaCalibrationAndSmearingTool.cxx.o] Error 1
#17 11.42 gmake[1]: *** [CMakeFiles/Makefile2:1066: ColumnarPrototype/CMakeFiles/ColumnarPrototypeLib.dir/all] Error 2
#17 11.42 gmake[1]: *** Waiting for unfinished jobs....

I think we're going to need to address this in https://gitlab.cern.ch/gstark/pycolumnarprototype.git. cc @ekourlit @nilserik78

@nilserik78
Copy link

If this is based on my tool conversions please use AnalysisBase 25.2.13.

@matthewfeickert
Copy link
Member Author

I'm not sure what the issue is at the moment, but if it is related to the work you're doing then we'll have to wait on @fengpinghu's user request given

$ docker run --rm -ti gitlab-registry.cern.ch/atlas/athena/analysisbase:25.2.13 /bin/bash -c '. /release_setup.sh && root --version'
Configured GCC from: /opt/lcg/gcc/13.1.0-b3d18/x86_64-el9/bin/gcc
Configured AnalysisBase from: /usr/AnalysisBase/25.2.13/InstallArea/x86_64-el9-gcc13-opt
ROOT Version: 6.28/12
Built for linuxx8664gcc on Jan 30 2024, 08:17:35
From tags/v6-28-12@v6-28-12

@ekourlit
Copy link

ekourlit commented Sep 18, 2024

If this is based on my tool conversions please use AnalysisBase 25.2.13.

Just to clarify, this is still using the old stand-alone ColumnarPrototype from:

https://gitlab.cern.ch/krumnack/columnarprototype/-/tree/c87cb89ce78e886e88e5d567c48c38a98899ddf3

So it is not surprising that it doesn't work with latest releases. That's why we have AB-stable at 25.2.2.

@matthewfeickert
Copy link
Member Author

Just to clarify, this is still using the old stand-alone ColumnarPrototype from:

https://gitlab.cern.ch/krumnack/columnarprototype/-/tree/c87cb89ce78e886e88e5d567c48c38a98899ddf3

@ekourlit sorry I'm a bit behind on things. Should things be updated to a new repository?

@ekourlit
Copy link

No, the "new repository" will be AMG's fork: https://gitlab.cern.ch/atlas-asg/columnar-athena
But this will only work once we have the python binding within atlasexternals.

Makes sense?

@nilserik78
Copy link

Yes, that's the repository, and yes you'd have to first get nanobind into the externals. Once that is figured out you can actually build externals and the release from that branch, even if it isn't yet in the externals. You may have to update package_filters.txt to include PhysicsAnalysis/Columnar.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants