Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

usagov-2097-alert-message-missing-svg-names: added svg and aria code … #2085

Open
wants to merge 1 commit into
base: dev
Choose a base branch
from

Conversation

developer43
Copy link
Contributor

…for screen readers

Jira Task

https://cm-jira.usa.gov/browse/USAGOV-2097

Description

Added svg tag and aria label code to announce the background svg image

Type of Changes

  • New Feature
  • Bugfix
  • Frontend (Twig, Sass, JS)
    • Add screenshot showing what it should look like
  • Drupal Config (requires "drush cim")
  • New Modules (requires rebuild)
  • Documentation
  • Infrastructure
    • CMS
    • WAF
    • WWW
    • Egress
    • Tools
    • Cron
  • Other

Testing Instructions

Change Requirements

  • Requires New Documentation (Link: {})
  • Requires New Config
  • Requires New Content

Validation Steps

  1. Clear you cache (bin/drush cr)
  2. Goto http://localhost/avoid-foreclosure
  3. Start Voice Over on Mac (command F5) and tab through the left navigation
  4. Before you get the alert component you need to use the arrow key to get to the component, hold down the "control" and "option" keys together while using the right arrow key.
  5. You should hear the screen reader announce "info, region".
  6. Continue to hold down the "control" and "option" keys together while using the right arrow key and you should hear "info, image”
  7. Continue to hold down the "control" and "option" keys together while using the right arrow key and you should hear "Heading level 2, important”
  8. Continue to hold down the "control" and "option" keys together while using the right arrow key and you should hear the body text in the alert box
Screenshot 2024-11-20 at 8 35 08 AM Screenshot 2024-11-20 at 8 35 19 AM Screenshot 2024-11-20 at 8 35 31 AM

Security Review

  • Adds/updates software (including a library or Drupal module)
  • Communication with external service
  • Changes permissions or workflow
  • Requires SSPP updates

Reviewer Reminders

  • Reviewed code changes
  • Reviewed functionality
  • Security review complete or not required

Post PR Approval Instructions

Follow these steps as soon as you merge the new changes.

  1. Go to the USAGov Circle CI project.
  2. Find the commit of this pull request.
  3. Build and deploy the changes.
  4. Update the Jira ticket by changing the ticket status to Review in Test and add a comment. State whether the change is already visible on cms-dev.usa.gov and beta-dev.usa.gov, or if the deployment is still in process.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant