fix linter issue #99
Merged
fix linter issue #99
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jelenazivovic
force-pushed
the
jz_enableWholeFilesInLint
branch
from
c81080c to
dcebb00
Compare
GersonTrj
approved these changes
Mar 7, 2024
felipeumpierre
approved these changes
Mar 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the linter reusable workflow there is an option only-new-issues which is set to true which means that only new issues will be reported if it’s a pull request.
But this option generates golangci-lint command using —new-from-patch option which will make linter to skip the issues if they are not reported as the same line as the changes (it uses git diff, the issue is described here: https://golangci-lint.run/usage/faq/#why---new-from-rev-or---new-from-patch-dont-seem-to-be-working-in-some-cases).
As a fix, we have added new input for linter reusable workflow enable_whole_files which, if set to true, includes —whole-files option which makes linter to show the issues in any part of files that are updated. This may lead for some old issues that weren’t reported before to be reported now, but teams can set it to false if they don't want to deal with it right now.