fix: #120 remove DNS host validation for ICMP check type

uptime-com · Dec 4, 2024 · 7cfcda1 · 7cfcda1
1 parent c8d66c3
commit 7cfcda1
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 1 deletion.
diff --git a/internal/provider/attr_address.go b/internal/provider/attr_address.go
@@ -14,6 +14,14 @@ func AddressHostnameSchemaAttribute() schema.StringAttribute {
 	}
 }
 
+func AddressHostnameOrIPSchemaAttribute() schema.StringAttribute {
+	// Use this attribute when the address can be either a hostname or an IP (v4 or v6) address
+	// Validation in that case done by API.
+	return schema.StringAttribute{
+		Required: true,
+	}
+}
+
 func AddressHostnameSchemaAttributeDescription(desc string) schema.StringAttribute {
 	return schema.StringAttribute{
 		Description: desc,

diff --git a/internal/provider/resource_check_icmp.go b/internal/provider/resource_check_icmp.go
@@ -24,7 +24,7 @@ func NewCheckICMPResource(_ context.Context, p *providerImpl) resource.Resource
 					"id":                        IDSchemaAttribute(),
 					"url":                       URLSchemaAttribute(),
 					"name":                      NameSchemaAttribute(),
-					"address":                   AddressHostnameSchemaAttribute(),
+					"address":                   AddressHostnameOrIPSchemaAttribute(),
 					"contact_groups":            ContactGroupsSchemaAttribute(),
 					"locations":                 LocationsSchemaAttribute(p),
 					"tags":                      TagsSchemaAttribute(),