Skip to content
This repository has been archived by the owner on May 12, 2021. It is now read-only.

merge ios automation to develop #171

Open
wants to merge 8 commits into
base: develop
Choose a base branch
from
Open

merge ios automation to develop #171

wants to merge 8 commits into from

Conversation

flaneuring
Copy link
Contributor

No description provided.

@flaneuring
Copy link
Contributor Author

Added a smoke test to verify workflow of creating an identity in the app and updated tests to reflect Jason's fix for bug 165199796.

Copy link
Contributor

@simonas-notcat simonas-notcat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How can we run these tests locally? Can you add a command to package.json scripts for launching these tests?

name: Install appium server
command: |
npm install -g appium
npm install wd
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this a global package or local? If local, why isn't it in package.json

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I’m going to check if I can add installation of appium server to package.json

As for running tests locally, you have to install appium:
npm install -g appium
npm install wd
pip install Appium-Python-Client

Then launch appium in terminal by running “appium”
And in a separate terminal run the tests from repo “python testsuites/test.py”

@@ -198,6 +204,17 @@ jobs:
- run:
name: Fastlane
command: cd ~/uport-mobile/ios && bundle exec fastlane buildTheApp
- run:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe we should run bundle exec fastlane buildTheApp only if appium tests pass?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's a good point.

@codecov
Copy link

codecov bot commented Jul 22, 2019

Codecov Report

Merging #171 into develop will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##           develop     #171   +/-   ##
========================================
  Coverage    58.25%   58.25%           
========================================
  Files          233      233           
  Lines         6750     6750           
  Branches       977      977           
========================================
  Hits          3932     3932           
  Misses        2442     2442           
  Partials       376      376

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9638344...5261adc. Read the comment docs.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants