-
Notifications
You must be signed in to change notification settings - Fork 28
merge ios automation to develop #171
base: develop
Are you sure you want to change the base?
Conversation
Added a smoke test to verify workflow of creating an identity in the app and updated tests to reflect Jason's fix for bug 165199796. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How can we run these tests locally? Can you add a command to package.json scripts
for launching these tests?
name: Install appium server | ||
command: | | ||
npm install -g appium | ||
npm install wd |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this a global package or local? If local, why isn't it in package.json
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I’m going to check if I can add installation of appium server to package.json
As for running tests locally, you have to install appium:
npm install -g appium
npm install wd
pip install Appium-Python-Client
Then launch appium in terminal by running “appium”
And in a separate terminal run the tests from repo “python testsuites/test.py”
@@ -198,6 +204,17 @@ jobs: | |||
- run: | |||
name: Fastlane | |||
command: cd ~/uport-mobile/ios && bundle exec fastlane buildTheApp | |||
- run: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe we should run bundle exec fastlane buildTheApp
only if appium tests pass?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's a good point.
Codecov Report
@@ Coverage Diff @@
## develop #171 +/- ##
========================================
Coverage 58.25% 58.25%
========================================
Files 233 233
Lines 6750 6750
Branches 977 977
========================================
Hits 3932 3932
Misses 2442 2442
Partials 376 376 Continue to review full report at Codecov.
|
No description provided.