test: added test to show network name case-insensitive search

uport-project · Dec 17, 2019 · 7ff682d · 7ff682d
1 parent 0388ef4
commit 7ff682d
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 10 deletions.
diff --git a/core/src/main/java/me/uport/sdk/core/Networks.kt b/core/src/main/java/me/uport/sdk/core/Networks.kt
@@ -136,7 +136,7 @@ object Networks {
      */
     private fun getNetworkByName(name: String): EthNetwork? {
         for ((_, value) in NETWORK_CONFIG) {
-            if (value.name.toLowerCase() === name.toLowerCase()) {
+            if (value.name.toLowerCase() == name.toLowerCase()) {
                 return value
             }
         }

diff --git a/core/src/test/java/me/uport/sdk/core/NetworksTest.kt b/core/src/test/java/me/uport/sdk/core/NetworksTest.kt
@@ -52,18 +52,14 @@ class NetworksTest {
     }
 
     @Test
-    fun `throws error if the network name does not match`() {
-        assertThat {
-            Networks.get("manet")
-        }.thrownError {
-            isInstanceOf(IllegalStateException::class)
-        }
+    fun `can find a registered network using the different case name`() {
+        assertThat(Networks.get("MainNet")).isEqualTo(Networks.mainnet)
     }
 
-    @Test
-    fun `throws error if the network name cases does not match`() {
+        @Test
+    fun `throws error if the network name does not match`() {
         assertThat {
-            Networks.get("Mainnet")
+            Networks.get("manet")
         }.thrownError {
             isInstanceOf(IllegalStateException::class)
         }